[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
TBR=avi@chromium.org (trivial cocoa change)

Committed: https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a
Cr-Commit-Position: refs/heads/master@{#380686}

[Devlin, 2016-03-11 00:07:25]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org, sky@chromium.org

[Devlin, 2016-03-11 00:07:25]

Finnur and Scott, mind taking a look?
finnur - everything
sky - app_menu.cc

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/app_menu.cc (left):

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/app_menu.cc:1156: if
(!extension_toolbar->ShouldShow()) {
This should be unnecessary with ToolbarActionsBar::NeedsOverflow(), which is
what determines whether or not we add the IDC_EXTENSIONS_OVERFLOW_MENU item to
the model.

[sky, 2016-03-11 05:13:27]

app_menu LGTM

[Finnur, 2016-03-11 15:10:11]

LGTM, one nit.

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:288: // user can drag an icon
into the app menu).
This comment needs updating. Could actually do with explaining these new
conditions, because they are non-obvious.

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:609: // One extension
in the overflow menu, none on the main bar. Overflow needed.
s/One/Set one/

[Devlin, 2016-03-11 17:31:59]

Description was changed from

==========
[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
==========

to

==========
[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
TBR=avi@chromium.org (trivial cocoa change)
==========

[Devlin, 2016-03-11 17:32:10]

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:288: // user can drag an icon
into the app menu).
On 2016/03/11 15:10:11, Finnur wrote:
> This comment needs updating. Could actually do with explaining these new
> conditions, because they are non-obvious.

Done.

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/1782223002/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:609: // One extension
in the overflow menu, none on the main bar. Overflow needed.
On 2016/03/11 15:10:11, Finnur wrote:
> s/One/Set one/

Done.

[Devlin, 2016-03-11 17:32:17]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-11 17:32:18]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1782223002/#ps20001
(title: "Finnur's")

[commit-bot: I haz the power, 2016-03-11 17:33:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782223002/20001

[commit-bot: I haz the power, 2016-03-11 18:52:29]

Description was changed from

==========
[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
TBR=avi@chromium.org (trivial cocoa change)
==========

to

==========
[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
TBR=avi@chromium.org (trivial cocoa change)
==========

[commit-bot: I haz the power, 2016-03-11 18:52:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 18:53:59]

Description was changed from

==========
[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
TBR=avi@chromium.org (trivial cocoa change)
==========

to

==========
[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG=593302
TBR=avi@chromium.org (trivial cocoa change)

Committed: https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a
Cr-Commit-Position: refs/heads/master@{#380686}
==========

[commit-bot: I haz the power, 2016-03-11 18:54:00]

Patchset 2 (id:??) landed as
https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a
Cr-Commit-Position: refs/heads/master@{#380686}