[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

chrome/browser/ui/views/toolbar/app_menu.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/app_menu.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 1135 matching lines @@
       item->SetMargins(top_margin, bottom_margin);
     }
 
     if (model->GetTypeAt(i) == MenuModel::TYPE_SUBMENU)
       PopulateMenu(item, model->GetSubmenuModelAt(i));
 
     switch (model->GetCommandIdAt(i)) {
       case IDC_EXTENSIONS_OVERFLOW_MENU: {
         scoped_ptr<ExtensionToolbarMenuView> extension_toolbar(
             new ExtensionToolbarMenuView(browser_, this, item));
-        if (!extension_toolbar->ShouldShow()) {

[Devlin, 2016/03/11 00:07:25]

This should be unnecessary with ToolbarActionsBar::NeedsOverflow(), which is
what determines whether or not we add the IDC_EXTENSIONS_OVERFLOW_MENU item to
the model.

-          item->SetVisible(false);
-          extension_toolbar_ = nullptr;
-          break;
-        }
         if (ui::MaterialDesignController::IsModeMaterial()) {
           for (int i = 0; i < extension_toolbar->contents()->child_count();
                ++i) {
             View* action_view = extension_toolbar->contents()->child_at(i);
             action_view->set_background(new InMenuButtonBackground(
                 InMenuButtonBackground::ROUNDED_BUTTON));
           }
         }
         extension_toolbar_ = extension_toolbar.get();
         item->AddChildView(extension_toolbar.release());
@@ skipping 121 matching lines @@
                                 0,
                                 BookmarkMenuDelegate::SHOW_PERMANENT_FOLDERS,
                                 BOOKMARK_LAUNCH_LOCATION_WRENCH_MENU);
 }
 
 int AppMenu::ModelIndexFromCommandId(int command_id) const {
   CommandIDToEntry::const_iterator ix = command_id_to_entry_.find(command_id);
   DCHECK(ix != command_id_to_entry_.end());
   return ix->second.second;
 }