chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc - Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finnur's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/bind.h"	5 #include "base/bind.h"

6 #include "base/bind_helpers.h"	6 #include "base/bind_helpers.h"

7 #include "base/run_loop.h"	7 #include "base/run_loop.h"

8 #include "chrome/browser/extensions/active_script_controller.h"	8 #include "chrome/browser/extensions/active_script_controller.h"

9 #include "chrome/browser/ui/extensions/extension_action_view_controller.h"	9 #include "chrome/browser/ui/extensions/extension_action_view_controller.h"

10 #include "chrome/browser/ui/extensions/icon_with_badge_image_source.h"	10 #include "chrome/browser/ui/extensions/icon_with_badge_image_source.h"

(...skipping 208 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
219 visibility_label);	219 visibility_label);

220 };	220 };

221	221

222 check_visibility_string(toolbar_actions_bar()->GetActions()[0],	222 check_visibility_string(toolbar_actions_bar()->GetActions()[0],

223 IDS_EXTENSIONS_HIDE_BUTTON_IN_MENU);	223 IDS_EXTENSIONS_HIDE_BUTTON_IN_MENU);

224 toolbar_model()->SetVisibleIconCount(0u);	224 toolbar_model()->SetVisibleIconCount(0u);

225 check_visibility_string(overflow_bar()->GetActions()[0],	225 check_visibility_string(overflow_bar()->GetActions()[0],

226 IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR);	226 IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR);

227 base::RunLoop run_loop;	227 base::RunLoop run_loop;

228 toolbar_actions_bar()->PopOutAction(toolbar_actions_bar()->GetActions()[0],	228 toolbar_actions_bar()->PopOutAction(toolbar_actions_bar()->GetActions()[0],

	229 false,

229 run_loop.QuitClosure());	230 run_loop.QuitClosure());

230 run_loop.Run();	231 run_loop.Run();

231 check_visibility_string(toolbar_actions_bar()->GetActions()[0],	232 check_visibility_string(toolbar_actions_bar()->GetActions()[0],

232 IDS_EXTENSIONS_KEEP_BUTTON_IN_TOOLBAR);	233 IDS_EXTENSIONS_KEEP_BUTTON_IN_TOOLBAR);

233 }	234 }

OLD	NEW