Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3663)

Unified Diff: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc

Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finnur's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
diff --git a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
index 659c61e63fcd381424cac2fd010e3473092f1be6..c430a7d04fca38c959e5cd119ce6752f76978682 100644
--- a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
+++ b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
@@ -41,9 +41,6 @@ ExtensionToolbarMenuView::ExtensionToolbarMenuView(
container_ = new BrowserActionsContainer(browser_, main);
container_->Init();
SetContents(container_);
- // We Layout() the container here so that we know the number of actions
- // that will be visible in ShouldShow().
- container_->Layout();
// Listen for the drop to finish so we can close the app menu, if necessary.
toolbar_actions_bar_observer_.Add(main->toolbar_actions_bar());
@@ -60,11 +57,6 @@ ExtensionToolbarMenuView::ExtensionToolbarMenuView(
ExtensionToolbarMenuView::~ExtensionToolbarMenuView() {
}
-bool ExtensionToolbarMenuView::ShouldShow() {
- return app_menu_->for_drop() ||
- container_->VisibleBrowserActionsAfterAnimation();
-}
-
gfx::Size ExtensionToolbarMenuView::GetPreferredSize() const {
gfx::Size s = views::ScrollView::GetPreferredSize();
// views::ScrollView::GetPreferredSize() includes the contents' size, but
« no previous file with comments | « chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698