chrome/browser/ui/views/toolbar/app_menu.cc - Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finnur's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc ('k') | chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/app_menu.cc

diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc

index 092007077fda43c58a8734a1b019b588f79fb734..41a134aabc61f1be938c3349f93e3e6c2cc4f6d1 100644

--- a/chrome/browser/ui/views/toolbar/app_menu.cc

+++ b/chrome/browser/ui/views/toolbar/app_menu.cc

@@ -1153,11 +1153,6 @@ void AppMenu::PopulateMenu(MenuItemView* parent, MenuModel* model) {

case IDC_EXTENSIONS_OVERFLOW_MENU: {

scoped_ptr<ExtensionToolbarMenuView> extension_toolbar(

new ExtensionToolbarMenuView(browser_, this, item));

- if (!extension_toolbar->ShouldShow()) {

- item->SetVisible(false);

- extension_toolbar_ = nullptr;

- break;

- }

if (ui::MaterialDesignController::IsModeMaterial()) {

for (int i = 0; i < extension_toolbar->contents()->child_count();

++i) {