chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc - Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

Issue 1782223002: [Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finnur's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_action_view_controller.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

diff --git a/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc b/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

index dc33417048a2e53678996066158773037220eaa6..020dd96225fb57c5ca171a773bbf5ae4fe2fc56e 100644

--- a/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

+++ b/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

@@ -226,6 +226,7 @@ TEST_P(ToolbarActionsBarRedesignUnitTest, ExtensionActionContextMenu) {

IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR);

base::RunLoop run_loop;

toolbar_actions_bar()->PopOutAction(toolbar_actions_bar()->GetActions()[0],

+ false,

run_loop.QuitClosure());

run_loop.Run();

check_visibility_string(toolbar_actions_bar()->GetActions()[0],