Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1776143003: Remove groups handling from password manager metrics util (Closed)

Created:
4 years, 9 months ago by vabr (Chromium)
Modified:
4 years, 9 months ago
Reviewers:
vasilii, Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, asvitkine+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@593295_unify_enums
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove groups handling from password manager metrics util BUG=593295 Committed: https://crrev.com/229e744a728a91ab3753882fa4413f10c28678cd Cr-Commit-Position: refs/heads/master@{#380384}

Patch Set 1 #

Patch Set 2 : Remove also test #

Patch Set 3 : Fix compile #

Patch Set 4 : Also remove the pref #

Total comments: 2

Patch Set 5 : Keep suffixes, marked as obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -262 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.h View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 1 2 4 chunks +5 lines, -30 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.h View 2 chunks +0 lines, -28 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.cc View 2 chunks +0 lines, -83 lines 0 comments Download
D components/password_manager/core/browser/password_manager_metrics_util_unittest.cc View 1 1 chunk +0 lines, -82 lines 0 comments Download
M components/password_manager/core/common/password_manager_pref_names.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M components/password_manager/core/common/password_manager_pref_names.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1781633002 Patch 40001

Messages

Total messages: 11 (4 generated)
vabr (Chromium)
Hi Vasilii and Ilya, Ilya: Please review histograms.xml. Vasilii: Please review everything else. Cheers, Vaclav
4 years, 9 months ago (2016-03-09 15:33:45 UTC) #2
vasilii
lgtm
4 years, 9 months ago (2016-03-09 18:27:04 UTC) #3
Ilya Sherman
lgtm https://codereview.chromium.org/1776143003/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1776143003/diff/60001/tools/metrics/histograms/histograms.xml#oldcode87969 tools/metrics/histograms/histograms.xml:87969: -</histogram_suffixes> nit: Please leave the suffixes in place, ...
4 years, 9 months ago (2016-03-09 20:18:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776143003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776143003/80001
4 years, 9 months ago (2016-03-10 08:42:02 UTC) #7
vabr (Chromium)
Thank you both for reviews! Comment addressed, sending to CQ now. Cheers, Vaclav https://codereview.chromium.org/1776143003/diff/60001/tools/metrics/histograms/histograms.xml File ...
4 years, 9 months ago (2016-03-10 08:42:16 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-10 09:58:48 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 09:59:58 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/229e744a728a91ab3753882fa4413f10c28678cd
Cr-Commit-Position: refs/heads/master@{#380384}

Powered by Google App Engine
This is Rietveld 408576698