Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Issue 1781633002: Mark PasswordManager.InfoBarResponse as obsolete (Closed)

Created:
4 years, 9 months ago by vabr (Chromium)
Modified:
4 years, 9 months ago
Reviewers:
Mike West, Ilya Sherman
CC:
asvitkine+watch_chromium.org, chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, sdefresne+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@593295_remove_groups_code
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark PasswordManager.InfoBarResponse as obsolete This metric has long since been replaced by UIDismissalReason. BUG=593295 Committed: https://crrev.com/7018e114b7486f463a888e57318dbb7b505a6e85 Cr-Commit-Position: refs/heads/master@{#380389}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Just rebased #

Messages

Total messages: 10 (4 generated)
vabr (Chromium)
Ilya, please review histograms.xml. Mike, please review the CL. Please note that we have not ...
4 years, 9 months ago (2016-03-09 15:38:10 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years, 9 months ago (2016-03-09 20:17:36 UTC) #3
Mike West
LGTM, thanks.
4 years, 9 months ago (2016-03-10 08:44:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781633002/40001
4 years, 9 months ago (2016-03-10 10:55:01 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 11:51:02 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 11:52:10 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7018e114b7486f463a888e57318dbb7b505a6e85
Cr-Commit-Position: refs/heads/master@{#380389}

Powered by Google App Engine
This is Rietveld 408576698