Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 1776143003: Remove groups handling from password manager metrics util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_unify_enums
Patch Set: Keep suffixes, marked as obsolete Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 354a685082a430cad09639de9e7086b2fcb41c22..7a8fd55bbb5f19b21da26a9a5e431dc4bfbca09d 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -9,8 +9,6 @@
#include <string>
-class PrefService;
-
namespace password_manager {
namespace metrics_util {
@@ -123,36 +121,10 @@ enum MultiAccountUpdateBubbleUserAction {
MULTI_ACCOUNT_UPDATE_BUBBLE_USER_ACTION_COUNT
};
-// We monitor the performance of the save password heuristic for a handful of
-// domains. For privacy reasons we are not reporting UMA signals by domain, but
-// by a domain group. A domain group can contain multiple domains, and a domain
-// can be contained in multiple groups.
-// For more information see http://goo.gl/vUuFd5.
-
-// The number of groups in which each monitored website appears.
-// It is a half of the total number of groups.
-const size_t kGroupsPerDomain = 10u;
-
-// Check whether the |url_host| is monitored or not. If yes, we return
-// the id of the group which contains the domain name otherwise
-// returns 0. |pref_service| needs to be the profile preference service.
-size_t MonitoredDomainGroupId(const std::string& url_host,
- PrefService* pref_service);
-
-// A version of the UMA_HISTOGRAM_ENUMERATION macro that allows the |name|
-// to vary over the program's runtime.
-void LogUMAHistogramEnumeration(const std::string& name,
- int sample,
- int boundary_value);
-
// A version of the UMA_HISTOGRAM_BOOLEAN macro that allows the |name|
// to vary over the program's runtime.
void LogUMAHistogramBoolean(const std::string& name, bool sample);
-// Returns a string which contains group_|group_id|. If the
-// |group_id| corresponds to an unmonitored domain returns an empty string.
-std::string GroupIdToString(size_t group_id);
-
// Log the |reason| a user dismissed the password manager UI.
void LogUIDismissalReason(UIDismissalReason reason);

Powered by Google App Engine
This is Rietveld 408576698