Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1776143003: Remove groups handling from password manager metrics util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_unify_enums
Patch Set: Keep suffixes, marked as obsolete Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/save_password_infobar_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 #if defined(OS_MACOSX) || BUILDFLAG(ANDROID_JAVA_UI) 240 #if defined(OS_MACOSX) || BUILDFLAG(ANDROID_JAVA_UI)
241 if (form_to_save->IsBlacklisted()) 241 if (form_to_save->IsBlacklisted())
242 return false; 242 return false;
243 #if BUILDFLAG(ANDROID_JAVA_UI) 243 #if BUILDFLAG(ANDROID_JAVA_UI)
244 if (update_password && IsUpdatePasswordUIEnabled()) { 244 if (update_password && IsUpdatePasswordUIEnabled()) {
245 UpdatePasswordInfoBarDelegate::Create(web_contents(), 245 UpdatePasswordInfoBarDelegate::Create(web_contents(),
246 std::move(form_to_save)); 246 std::move(form_to_save));
247 return true; 247 return true;
248 } 248 }
249 #endif 249 #endif
250 std::string uma_histogram_suffix( 250 SavePasswordInfoBarDelegate::Create(web_contents(),
251 password_manager::metrics_util::GroupIdToString( 251 std::move(form_to_save));
252 password_manager::metrics_util::MonitoredDomainGroupId(
253 form_to_save->pending_credentials().signon_realm, GetPrefs())));
254 SavePasswordInfoBarDelegate::Create(web_contents(), std::move(form_to_save),
255 uma_histogram_suffix);
256 #else 252 #else
257 NOTREACHED() << "Aura platforms should always use the bubble"; 253 NOTREACHED() << "Aura platforms should always use the bubble";
258 #endif 254 #endif
259 } 255 }
260 return true; 256 return true;
261 } 257 }
262 258
263 bool ChromePasswordManagerClient::PromptUserToChooseCredentials( 259 bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
264 ScopedVector<autofill::PasswordForm> local_forms, 260 ScopedVector<autofill::PasswordForm> local_forms,
265 ScopedVector<autofill::PasswordForm> federated_forms, 261 ScopedVector<autofill::PasswordForm> federated_forms,
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 608
613 const password_manager::CredentialsFilter* 609 const password_manager::CredentialsFilter*
614 ChromePasswordManagerClient::GetStoreResultFilter() const { 610 ChromePasswordManagerClient::GetStoreResultFilter() const {
615 return &credentials_filter_; 611 return &credentials_filter_;
616 } 612 }
617 613
618 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager() 614 const password_manager::LogManager* ChromePasswordManagerClient::GetLogManager()
619 const { 615 const {
620 return log_manager_.get(); 616 return log_manager_.get();
621 } 617 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/save_password_infobar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698