Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.h

Issue 1776143003: Remove groups handling from password manager metrics util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_unify_enums
Patch Set: Keep suffixes, marked as obsolete Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/save_password_infobar_delegate.h
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.h b/chrome/browser/password_manager/save_password_infobar_delegate.h
index 5de8f896c257b2e35f2451c533c0f5149a4fba0d..a95c82a46a411763b28f5046fb7424e37ba35d96 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate.h
+++ b/chrome/browser/password_manager/save_password_infobar_delegate.h
@@ -32,14 +32,10 @@ class SavePasswordInfoBarDelegate : public PasswordManagerInfoBarDelegate {
public:
// If we won't be showing the one-click signin infobar, creates a save
// password infobar and delegate and adds the infobar to the InfoBarService
- // for |web_contents|. |uma_histogram_suffix| is empty, or one of the
- // "group_X" suffixes used in the histogram names for infobar usage reporting;
- // if empty, the usage is not reported, otherwise the suffix is used to choose
- // the right histogram.
+ // for |web_contents|.
static void Create(
content::WebContents* web_contents,
- scoped_ptr<password_manager::PasswordFormManager> form_to_save,
- const std::string& uma_histogram_suffix);
+ scoped_ptr<password_manager::PasswordFormManager> form_to_save);
~SavePasswordInfoBarDelegate() override;
@@ -57,7 +53,6 @@ class SavePasswordInfoBarDelegate : public PasswordManagerInfoBarDelegate {
SavePasswordInfoBarDelegate(
content::WebContents* web_contents,
scoped_ptr<password_manager::PasswordFormManager> form_to_save,
- const std::string& uma_histogram_suffix,
bool is_smartlock_branding_enabled,
bool should_show_first_run_experience);
@@ -73,10 +68,6 @@ class SavePasswordInfoBarDelegate : public PasswordManagerInfoBarDelegate {
// signal.
base::ElapsedTimer timer_;
- // The group name corresponding to the domain name of |form_to_save_| if the
- // form is on a monitored domain. Otherwise, an empty string.
- const std::string uma_histogram_suffix_;
-
// Records source from where infobar was triggered.
// Infobar appearance (message, buttons) depends on value of this parameter.
password_manager::CredentialSourceType source_type_;

Powered by Google App Engine
This is Rietveld 408576698