Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1776143003: Remove groups handling from password manager metrics util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_unify_enums
Patch Set: Also remove the pref Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/password_manager/core/common/password_manager_pref_names.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 82f8b6b664bd059e3a527d4ec1886c86ce9e2f84..2e40cb8172cde023e9793331bb564f9f42ed6da3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -34288,6 +34288,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="PasswordManager.SavePasswordPromptDisappearedQuickly"
enum="Boolean">
<owner>vabr@chromium.org</owner>
+ <obsolete>
+ Deprecated as of 03/2016.
+ </obsolete>
<summary>
Indicates whether the save password prompt disappeared in less than one
second. This most likely indicates that the prompt was dismissed
@@ -34298,12 +34301,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="PasswordManager.SavePasswordPromptDisplayed" enum="Boolean">
<owner>vabr@chromium.org</owner>
+ <obsolete>
+ Deprecated as of 03/2016.
+ </obsolete>
<summary>Indicates whether the save password prompt was displayed.</summary>
</histogram>
<histogram name="PasswordManager.SavePasswordPromptResponse"
enum="SavePasswordPromptResponseType">
<owner>vabr@chromium.org</owner>
+ <obsolete>
+ Deprecated as of 03/2016.
+ </obsolete>
<summary>
Breakdown of which response the user selected from the save password prompt.
</summary>
@@ -87938,36 +87947,6 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="PasswordManager.TotalAccounts"/>
</histogram_suffixes>
-<histogram_suffixes name="PasswordManagerMonitor">
- <suffix name="group_1" label="group 1"/>
- <suffix name="group_2" label="group 2"/>
- <suffix name="group_3" label="group 3"/>
- <suffix name="group_4" label="group 4"/>
- <suffix name="group_5" label="group 5"/>
- <suffix name="group_6" label="group 6"/>
- <suffix name="group_7" label="group 7"/>
- <suffix name="group_8" label="group 8"/>
- <suffix name="group_9" label="group 9"/>
- <suffix name="group_10" label="group 10"/>
- <suffix name="group_11" label="group 11"/>
- <suffix name="group_12" label="group 12"/>
- <suffix name="group_13" label="group 13"/>
- <suffix name="group_14" label="group 14"/>
- <suffix name="group_15" label="group 15"/>
- <suffix name="group_16" label="group 16"/>
- <suffix name="group_17" label="group 17"/>
- <suffix name="group_18" label="group 18"/>
- <suffix name="group_19" label="group 19"/>
- <suffix name="group_20" label="group 20"/>
- <suffix name="" label=""/>
- <affected-histogram name="PasswordManager.LinuxBackendStatistics"/>
- <affected-histogram name="PasswordManager.ProvisionalSaveFailure"/>
- <affected-histogram
- name="PasswordManager.SavePasswordPromptDisappearedQuickly"/>
- <affected-histogram name="PasswordManager.SavePasswordPromptDisplayed"/>
- <affected-histogram name="PasswordManager.SavePasswordPromptResponse"/>
-</histogram_suffixes>
Ilya Sherman 2016/03/09 20:18:29 nit: Please leave the suffixes in place, but mark
vabr (Chromium) 2016/03/10 08:42:16 Done.
-
<histogram_suffixes name="PasswordReuseSourceRealm" separator=".">
<suffix name="FromHttpRealm"
label="The account in question was saved on an HTTP site."/>
« no previous file with comments | « components/password_manager/core/common/password_manager_pref_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698