Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1776143003: Remove groups handling from password manager metrics util (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_unify_enums
Patch Set: Keep suffixes, marked as obsolete Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 620d14b95a9ab3913e4f457d834dc378d712160b..65d8f00a809cab66cea750cf102db96c61c0fae0 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -163,7 +163,6 @@ void PasswordManager::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);
registry->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords,
true);
- registry->RegisterListPref(prefs::kPasswordManagerGroupsForDomains);
#if defined(OS_MACOSX)
registry->RegisterIntegerPref(prefs::kKeychainMigrationStatus,
static_cast<int>(MigrationStatus::NOT_STARTED));
@@ -370,16 +369,6 @@ void PasswordManager::RecordFailure(ProvisionalSaveFailure failure,
UMA_HISTOGRAM_ENUMERATION(
"PasswordManager.ProvisionalSaveFailure", failure, MAX_FAILURE_VALUE);
- std::string group_name =
- metrics_util::GroupIdToString(metrics_util::MonitoredDomainGroupId(
- form_origin.host(), client_->GetPrefs()));
- if (!group_name.empty()) {
- metrics_util::LogUMAHistogramEnumeration(
- "PasswordManager.ProvisionalSaveFailure_" + group_name,
- failure,
- MAX_FAILURE_VALUE);
- }
-
if (logger) {
switch (failure) {
case SAVING_DISABLED:

Powered by Google App Engine
This is Rietveld 408576698