Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed)

Created:
4 years, 9 months ago by nyquist
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #5 id:80001 of https://codereview.chromium.org/1743763004/ ) Reason for revert: Causes content_unittests to fail on GinJavaBridgeValueConverterTest.TypedArrays for Android on a bunch of testers: Marshmallow Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/3117 Marshmallow 64 bit Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/1010 Lollipop Tablet Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/2108 Lollipop Phone Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/3403 Lollipop Low-end Tester - https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/2681 git bisect succesfully identified this CL as the culprit: 83013584d091473d3a5fee6a823bc63b223a472c is the first bad commit See http://crbug.com/592906 for details. Original issue's description: > Use v8::MicrotasksScope internally in V8RecursionScope. > > If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression, > along with other cleanups. > > BUG=585949 > > Committed: https://crrev.com/83013584d091473d3a5fee6a823bc63b223a472c > Cr-Commit-Position: refs/heads/master@{#379574} TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585949 Committed: https://crrev.com/04f19da143d8d119b781cfa1574c3acc47e4c61c Cr-Commit-Position: refs/heads/master@{#379781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -106 lines) Patch
M chrome/test/base/v8_unit_test.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/safe_builtins.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gin/run_microtasks_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M gin/run_microtasks_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp View 7 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp View 11 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 3 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 5 chunks +31 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h View 1 chunk +31 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Microtask.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamReaderTest.cpp View 21 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nyquist
Created Revert of Use v8::MicrotasksScope internally in V8RecursionScope.
4 years, 9 months ago (2016-03-08 08:00:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765423004/1
4 years, 9 months ago (2016-03-08 08:00:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765423004/1
4 years, 9 months ago (2016-03-08 08:01:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 08:01:59 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 08:04:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04f19da143d8d119b781cfa1574c3acc47e4c61c
Cr-Commit-Position: refs/heads/master@{#379781}

Powered by Google App Engine
This is Rietveld 408576698