third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp - Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

index 1c946d962aa5e2a3f59db2b103035a3c279fcae2..b6cf586b9ec1b3bd68085d6b2213a98245ad2a00 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

@@ -60,7 +60,7 @@

createClosure(callback, v8::Undefined(isolate()), isolate());

// Execute all pending microtasks

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

}

OwnPtr<DummyPageHolder> m_pageHolder;

@@ -96,7 +96,7 @@

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

@@ -111,14 +111,14 @@

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("hello", onFulfilled);

EXPECT_EQ(String(), onRejected);

resolver->resolve("bye");

resolver->reject("bye");

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("hello", onFulfilled);

EXPECT_EQ(String(), onRejected);

@@ -144,7 +144,7 @@

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

@@ -159,14 +159,14 @@

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ("hello", onRejected);

resolver->resolve("bye");

resolver->reject("bye");

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ("hello", onRejected);

@@ -196,7 +196,7 @@

}

resolver->resolve("hello");

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ(String(), onRejected);

@@ -321,7 +321,7 @@

}

resolver->resolve();

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("undefined", onFulfilled);

EXPECT_EQ(String(), onRejected);

@@ -345,7 +345,7 @@

}

resolver->reject();

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(String(), onFulfilled);

EXPECT_EQ("undefined", onRejected);