third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp - Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp ('k') | third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

index 1c4030cb6521e26429a539ecca0335cbbfb0b701..7834ae90ae2227eeb0bdd739aabbe60738cc3f0b 100644

--- a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

@@ -249,7 +249,7 @@

{

ScriptValue onReject;

promise.then(UnreachableFunction::create(scriptState()), TestFunction::create(scriptState(), &onReject));

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

return onReject;

}

@@ -263,7 +263,7 @@

{

ScriptValue onResolve;

promise.then(TestFunction::create(scriptState(), &onResolve), UnreachableFunction::create(scriptState()));

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

return onResolve;

}