Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp

Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
index 49ddfe5e32923d4bf56040048d234de484f1b274..a76e6d0a43763a02e789b044b78a306683b73063 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
@@ -12,7 +12,6 @@
#include "bindings/core/v8/V8BindingForTesting.h"
#include "bindings/core/v8/V8BindingMacros.h"
#include "bindings/core/v8/V8IteratorResultValue.h"
-#include "bindings/core/v8/V8RecursionScope.h"
#include "bindings/core/v8/V8ThrowException.h"
#include "core/dom/Document.h"
#include "core/streams/ReadableStreamController.h"
@@ -139,7 +138,7 @@
~ReadableStreamOperationsTest() override
{
// Execute all pending microtasks
- v8::MicrotasksScope::PerformCheckpoint(isolate());
+ isolate()->RunMicrotasks();
EXPECT_FALSE(m_block.HasCaught());
}
@@ -150,7 +149,6 @@
{
v8::Local<v8::String> source;
v8::Local<v8::Script> script;
- V8RecursionScope::MicrotaskSuppression microtasks(isolate());
if (!v8Call(v8::String::NewFromUtf8(isolate(), s, v8::NewStringType::kNormal), source)) {
ADD_FAILURE();
return ScriptValue();
@@ -255,12 +253,12 @@
Function::createFunction(scriptState(), it2),
NotReached::createFunction(scriptState()));
- v8::MicrotasksScope::PerformCheckpoint(isolate());
+ isolate()->RunMicrotasks();
EXPECT_FALSE(it1->isSet());
EXPECT_FALSE(it2->isSet());
ASSERT_FALSE(evalWithPrintingError("controller.enqueue('hello')").isEmpty());
- v8::MicrotasksScope::PerformCheckpoint(isolate());
+ isolate()->RunMicrotasks();
EXPECT_TRUE(it1->isSet());
EXPECT_TRUE(it1->isValid());
EXPECT_FALSE(it1->isDone());
@@ -268,7 +266,7 @@
EXPECT_FALSE(it2->isSet());
ASSERT_FALSE(evalWithPrintingError("controller.close()").isEmpty());
- v8::MicrotasksScope::PerformCheckpoint(isolate());
+ isolate()->RunMicrotasks();
EXPECT_TRUE(it1->isSet());
EXPECT_TRUE(it1->isValid());
EXPECT_FALSE(it1->isDone());
@@ -311,7 +309,7 @@
ReadableStreamOperations::read(scriptState(), reader).then(Function::createFunction(scriptState(), it2), NotReached::createFunction(scriptState()));
ReadableStreamOperations::read(scriptState(), reader).then(Function::createFunction(scriptState(), it3), NotReached::createFunction(scriptState()));
- v8::MicrotasksScope::PerformCheckpoint(isolate());
+ isolate()->RunMicrotasks();
EXPECT_EQ(10, underlyingSource->desiredSize());
@@ -328,7 +326,7 @@
EXPECT_FALSE(it3->isSet());
underlyingSource->close();
- v8::MicrotasksScope::PerformCheckpoint(isolate());
+ isolate()->RunMicrotasks();
EXPECT_TRUE(it3->isSet());
EXPECT_TRUE(it3->isValid());
« no previous file with comments | « gin/run_microtasks_observer.cc ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698