third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp - Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp

Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/streams/ReadableStreamReaderTest.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp

diff --git a/third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp b/third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp

index 031ecddbdeb8e548d64d220adb58aaffbe9e5b11..fb52f46ccff665d8cef0a62c5e1b76f02f59cbf1 100644

--- a/third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp

+++ b/third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp

@@ -304,7 +304,7 @@

stream->read(scriptState());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ(ReadableStream::Readable, stream->stateInternal());

EXPECT_FALSE(stream->isPulling());

@@ -335,7 +335,7 @@

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_TRUE(onRejected.isNull());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("undefined", onFulfilled);

EXPECT_TRUE(onRejected.isNull());

}

@@ -358,7 +358,7 @@

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_TRUE(onRejected.isNull());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_EQ("NotFoundError: error", onRejected);

}

@@ -392,7 +392,7 @@

EXPECT_TRUE(onCancelFulfilled.isNull());

EXPECT_TRUE(onCancelRejected.isNull());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("undefined", onCancelFulfilled);

EXPECT_TRUE(onCancelRejected.isNull());

}

@@ -416,7 +416,7 @@

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_TRUE(onRejected.isNull());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_EQ("TypeError: this stream is locked to a ReadableStreamReader", onRejected);

@@ -563,7 +563,7 @@

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_TRUE(onRejected.isNull());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("undefined", onFulfilled);

EXPECT_TRUE(onRejected.isNull());

}

@@ -586,7 +586,7 @@

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_TRUE(onRejected.isNull());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isNull());

EXPECT_EQ("SyntaxError: some error", onRejected);

}