third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp - Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 1765423004: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

index 01d144ed721e712d28a40c537209c9d3e5a9e292..5c3fec72363e397e40cd40e892803a6e55db1316 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

@@ -83,7 +83,7 @@

createClosure(callback, v8::Undefined(m_scope.isolate()), m_scope.isolate());

// Execute all pending microtasks

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

}

String toString(const ScriptValue& value)

@@ -124,13 +124,13 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

resolver.resolve(v8String(isolate(), "hello"));

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("hello", toString(onFulfilled));

EXPECT_TRUE(onRejected.isEmpty());

@@ -148,7 +148,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("hello", toString(onFulfilled));

EXPECT_TRUE(onRejected.isEmpty());

@@ -165,13 +165,13 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

resolver.reject(v8String(isolate(), "hello"));

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_EQ("hello", toString(onRejected));

@@ -189,7 +189,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_EQ("hello", toString(onRejected));

@@ -226,7 +226,7 @@

EXPECT_TRUE(onRejected1.isEmpty());

EXPECT_TRUE(onRejected2.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_EQ("hello", toString(onFulfilled1));

EXPECT_EQ("hello", toString(onFulfilled2));

@@ -248,7 +248,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_EQ("hello", toString(onRejected));

@@ -264,7 +264,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_EQ("SyntaxError: some syntax error", toString(onRejected));

@@ -282,7 +282,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_FALSE(onFulfilled.isEmpty());

EXPECT_TRUE(toStringArray(onFulfilled).isEmpty());

@@ -304,7 +304,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_FALSE(onFulfilled.isEmpty());

Vector<String> values = toStringArray(onFulfilled);

@@ -329,7 +329,7 @@

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_TRUE(onRejected.isEmpty());

- v8::MicrotasksScope::PerformCheckpoint(isolate());

+ isolate()->RunMicrotasks();

EXPECT_TRUE(onFulfilled.isEmpty());

EXPECT_FALSE(onRejected.isEmpty());