Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17593006: mac: Update clients of scoped_nsobject.h. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, asanka, aboxhall+watch_chromium.org, sadrul, yusukes+watch_chromium.org, tzik+watch_chromium.org, amit, jeremya+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, rsesek+watch_chromium.org, jennb, dmazzoni+watch_chromium.org, Albert Bodenhamer, kinuko+watch, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, benjhayden+dwatch_chromium.org, jonathan.backer, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jamiewalch+watch_chromium.org, ahutter, dtseng+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, penghuang+watch_chromium.org, jianli, rmsousa+watch_chromium.org, yuzo+watch_chromium.org, weitaosu+watch_chromium.org, Raman Kakilate, sergeyu+watch_chromium.org, ctguil+watch_chromium.org, rouslan+autofillwatch_chromium.org, zork+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, hashimoto+watch_chromium.org, Ian Vollick, tfarina, Dmitry Titov, davidbarr+watch_chromium.org, garykac+watch_chromium.org, benquan, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, piman+watch_chromium.org, estade+watch_chromium.org, alexeypa+watch_chromium.org, James Su
Visibility:
Public.

Description

mac: Update clients of scoped_nsobject.h. 1.) The header is now in base/mac instead of base/memory 2.) The class is now in namespace base. This CL was created programmatically by running: 1.) git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g' for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done git commit -a -m headers # manually undo changes to gypi file git cl upload # patch set 1 2.) git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g' # manually undo comment changes in scoped_nsobject.h, tracking_area.h git commit -a -m format git cl upload # patch set 2 # Manually audit all files, file bugs and clean up bad clang-format decisions git cl upload # patch set 3 BUG=251957 TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208283

Patch Set 1 #

Patch Set 2 : base::, format #

Patch Set 3 : cleanups #

Total comments: 15

Patch Set 4 : iwyu, scoped_nsprotocol #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+2124 lines, -2091 lines) Patch
M ash/shell/shell_main_parts_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ash/test/test_suite_init.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/file_version_info_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/mac/mac_util.mm View 1 3 chunks +8 lines, -8 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 3 chunks +4 lines, -3 lines 0 comments Download
M base/mac/scoped_sending_event.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_support_ios.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_app_mode_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/app_controller_mac_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_application_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/download/download_status_updater_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/safari_importer.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/keystone_glue.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_finder_mac.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/tts_mac.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/image_capture_device.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/image_capture_device_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/image_capture_device_manager.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm View 1 8 chunks +20 lines, -26 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_controller_unittest.mm View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/animatable_image.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/animatable_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/animatable_view_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript_unittest.mm View 1 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_item_applescript_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript_test.mm View 1 12 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_account_chooser.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_account_chooser.mm View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_details_container.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_details_container.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_main_container.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_main_container.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.mm View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_textfield.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_textfield_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell_unittest.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm View 1 11 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/cocoa/background_gradient_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 12 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 1 19 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm View 1 2 2 chunks +9 lines, -9 lines 1 comment Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm View 1 8 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 9 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm View 1 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm View 1 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm View 1 7 chunks +30 lines, -36 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 5 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm View 1 4 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm View 1 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 4 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bubble_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bubble_view.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bubble_view_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/clickhold_button_cell.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/clickhold_button_cell_unittest.mm View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/color_chooser_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/command_observer_bridge_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm View 1 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_alert_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_animation.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_animation_unittest.mm View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_button.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_button_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm View 1 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 5 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details.h View 1 3 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm View 1 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller_unittest.mm View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_tree_node.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_tree_node.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/custom_frame_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/dock_icon.mm View 1 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_button.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_button_unittest.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell_unittest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm View 1 13 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_view_unittest.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/draggable_button.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/draggable_button.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/draggable_button_mixin.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/draggable_button_unittest.mm View 1 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm View 1 8 chunks +36 lines, -41 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fast_resize_view_unittest.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_cell_unittest.mm View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_text_field_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_view_unittest.mm View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/find_pasteboard_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_bubble_controller_unittest.mm View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/floating_bar_backing_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_view.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hyperlink_button_cell.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/hyperlink_button_cell.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/hyperlink_button_cell_unittest.mm View 1 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/hyperlink_text_view.mm View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/hyperlink_text_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell_unittest.mm View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_view_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_utilities.mm View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.mm View 1 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 2 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm View 1 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm View 1 7 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest_helper.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/button_decoration.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration_unittest.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/image_decoration.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/plus_decoration.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/star_decoration.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_button.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_button.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_button_unittest.mm View 1 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/nsview_additions_unittest.mm View 1 4 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_view_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_stack_window_cocoa.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_stack_window_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller.mm View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_signin_confirmation_dialog_cocoa.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_signin_confirmation_dialog_cocoa.mm View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller_browsertest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/run_loop_testing.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/run_loop_testing_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/speech_recognition_bubble_cocoa.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_cell_unittest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/styled_text_field_unittest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlay_separator_view_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_view_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 1 14 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_projecting_image_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_projecting_image_view_unittest.mm View 1 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 5 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbber_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbber_view.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbber_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view_unittest.mm View 1 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 1 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 1 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/wrench_toolbar_button_cell_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm View 1 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/vertical_gradient_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/vertical_gradient_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings_bubble_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings_bubble_controller.mm View 1 10 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/window_size_autosaver.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/window_size_autosaver_unittest.mm View 1 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/menu_tracked_root_view_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/recent_tabs_menu_model_delegate.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_button_cell_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tests/ui_gfx_image_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/mac/cfbundle_blocker.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/mac/nscoder_util_unittest.mm View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/mac/objc_method_swizzle.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/mac/objc_method_swizzle_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/mac/objc_zombie_unittest.mm View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 5 chunks +7 lines, -8 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_mac_unittest.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm View 1 2 2 chunks +3 lines, -3 lines 1 comment Download
M content/browser/geolocation/core_location_data_provider_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter_mac.mm View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_context_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_context_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/popup_menu_helper_mac.mm View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 6 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/webmenurunner_mac.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/webmenurunner_mac.mm View 1 2 5 chunks +10 lines, -10 lines 1 comment Download
M content/browser/web_contents/web_contents_view_mac.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac_unittest.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac_unittest.mm View 1 1 chunk +10 lines, -11 lines 0 comments Download
M content/common/mac/attributed_string_coder.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mac/attributed_string_coder_unittest.mm View 1 6 chunks +7 lines, -7 lines 0 comments Download
M content/common/mac/font_loader.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_browser_main_parts_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell_javascript_dialog_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_login_dialog_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_mac.mm View 1 3 chunks +4 lines, -3 lines 0 comments Download
M crypto/apple_keychain_ios.mm View 1 5 chunks +5 lines, -5 lines 0 comments Download
M net/base/platform_mime_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/continue_window_mac.mm View 1 3 chunks +5 lines, -5 lines 0 comments Download
M rlz/mac/lib/rlz_value_store_mac.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/skia_utils_mac_unittest.mm View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/app_list_view_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/app_list_window_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/app_list_window_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_window_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/apps_collection_view_drag_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/apps_collection_view_drag_manager.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.mm View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 5 chunks +5 lines, -5 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_view_item.mm View 1 8 chunks +10 lines, -10 lines 0 comments Download
M ui/app_list/cocoa/apps_search_box_controller.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/app_list/cocoa/apps_search_box_controller.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/apps_search_box_controller_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_controller.mm View 1 7 chunks +14 lines, -13 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_controller_unittest.mm View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_model_bridge.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/cocoa/current_user_menu_item_view.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/item_drag_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/item_drag_controller.mm View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/scroll_view_with_no_scrollbars.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/accelerators/platform_accelerator_cocoa.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_mac.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/cocoa/base_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/base_view_unittest.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hover_image_menu_button_cell.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hover_image_menu_button_cell.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/controls/hover_image_menu_button_unittest.mm View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/cocoa/find_pasteboard.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/focus_tracker.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/focus_tracker_unittest.mm View 1 6 chunks +12 lines, -9 lines 0 comments Download
M ui/base/cocoa/fullscreen_window_manager.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/fullscreen_window_manager_unittest.mm View 1 1 chunk +3 lines, -4 lines 0 comments Download
M ui/base/cocoa/hover_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/hover_button.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/hover_image_button.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/cocoa/hover_image_button_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/menu_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/menu_controller.mm View 1 2 3 chunks +3 lines, -3 lines 1 comment Download
M ui/base/cocoa/menu_controller_unittest.mm View 1 11 chunks +11 lines, -11 lines 0 comments Download
M ui/base/cocoa/nib_loading.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/nsgraphics_context_additions_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/tracking_area.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/tracking_area.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/tracking_area_unittest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cocoa/underlay_opengl_hosting_window.mm View 1 2 chunks +11 lines, -7 lines 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 2 chunks +4 lines, -5 lines 0 comments Download
M ui/base/test/ui_cocoa_test_helper.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/image/image_ios.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/image/image_mac.mm View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/image/image_mac_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/image/image_skia_util_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/platform_font_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_nsview.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_nsview.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 6 chunks +8 lines, -9 lines 0 comments Download
M ui/message_center/cocoa/notification_controller_unittest.mm View 1 8 chunks +8 lines, -8 lines 0 comments Download
M ui/message_center/cocoa/popup_collection.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/cocoa/popup_collection_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/popup_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/cocoa/popup_controller.mm View 1 2 1 chunk +5 lines, -5 lines 1 comment Download
M ui/message_center/cocoa/popup_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/settings_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/message_center/cocoa/settings_controller.mm View 1 5 chunks +8 lines, -7 lines 0 comments Download
M ui/message_center/cocoa/settings_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/status_item_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/status_item_view_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_controller.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_controller.mm View 1 2 1 chunk +1 line, -1 line 1 comment Download
M ui/message_center/cocoa/tray_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller.mm View 1 8 chunks +8 lines, -8 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot_mac_unittest.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/cursors/webcursor_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/user_agent/user_agent_util_ios.mm View 1 2 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Nico
This touched many ObjC lines, which clang-format hasn't seen as much testing on as it ...
7 years, 6 months ago (2013-06-24 20:54:03 UTC) #1
Mark Mentovai
I only looked at the first 100 or 150 or so files. The major pattern ...
7 years, 6 months ago (2013-06-24 21:29:47 UTC) #2
Mark Mentovai
I just looked at a handful more random files to try to assure myself that ...
7 years, 6 months ago (2013-06-24 21:37:27 UTC) #3
Nico
I did the IWYUs, I'd like to do the DIWYDUs in a follow-up if possible. ...
7 years, 6 months ago (2013-06-24 22:06:26 UTC) #4
Mark Mentovai
LGTM
7 years, 6 months ago (2013-06-24 22:31:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/17593006/29002
7 years, 6 months ago (2013-06-24 22:33:40 UTC) #6
Nico
Committed patchset #4 manually as r208283 (presubmit successful).
7 years, 6 months ago (2013-06-24 22:52:30 UTC) #7
Nico
7 years, 6 months ago (2013-06-25 01:09:48 UTC) #8
Message was sent while issue was closed. 
Good news: clang-format now gets one of the things it got wrong right, and the
remaining things are due to only 3.5 bugs:

https://codereview.chromium.org/17593006/diff/29002/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm (right):

https://codereview.chromium.org/17593006/diff/29002/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm:69: nil]);
Filed PR16435 and PR16436 for this.

https://codereview.chromium.org/17593006/diff/29002/chrome/browser/ui/cocoa/l...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/17593006/diff/29002/chrome/browser/ui/cocoa/l...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:555:
userInfo:info]);
Also http://llvm.org/PR15349.

https://codereview.chromium.org/17593006/diff/29002/content/browser/gamepad/g...
File content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm (right):

https://codereview.chromium.org/17593006/diff/29002/content/browser/gamepad/g...
content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm:67: nil]);
This is maybe partially PR16185.

https://codereview.chromium.org/17593006/diff/29002/content/browser/renderer_...
File content/browser/renderer_host/webmenurunner_mac.mm (right):

https://codereview.chromium.org/17593006/diff/29002/content/browser/renderer_...
content/browser/renderer_host/webmenurunner_mac.mm:72: writingDirection +
NSTextWritingDirectionOverride]);
Also PR15349.

https://codereview.chromium.org/17593006/diff/29002/ui/base/cocoa/menu_contro...
File ui/base/cocoa/menu_controller.mm (right):

https://codereview.chromium.org/17593006/diff/29002/ui/base/cocoa/menu_contro...
ui/base/cocoa/menu_controller.mm:188: [[NSAttributedString alloc]
initWithString:[(id)item title]
clang-format gets this right as of clang r184804.

https://codereview.chromium.org/17593006/diff/29002/ui/message_center/cocoa/p...
File ui/message_center/cocoa/popup_controller.mm (right):

https://codereview.chromium.org/17593006/diff/29002/ui/message_center/cocoa/p...
ui/message_center/cocoa/popup_controller.mm:105: defer:YES]);
I think this is http://llvm.org/PR15349.

https://codereview.chromium.org/17593006/diff/29002/ui/message_center/cocoa/t...
File ui/message_center/cocoa/tray_controller.mm (right):

https://codereview.chromium.org/17593006/diff/29002/ui/message_center/cocoa/t...
ui/message_center/cocoa/tray_controller.mm:37: defer:NO]);
This is http://llvm.org/PR15349 too.

https://codereview.chromium.org/17593006/diff/29002/webkit/common/user_agent/...
File webkit/common/user_agent/user_agent_util_ios.mm (right):

https://codereview.chromium.org/17593006/diff/29002/webkit/common/user_agent/...
webkit/common/user_agent/user_agent_util_ios.mm:114: initWithObjectsAndKeys:
Also PR16435 and PR16436

Powered by Google App Engine
This is Rietveld 408576698