Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript_unittest.mm

Issue 17593006: mac: Update clients of scoped_nsobject.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: iwyu, scoped_nsprotocol Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/memory/scoped_nsobject.h" 7 #include "base/mac/scoped_nsobject.h"
8 #include "base/strings/sys_string_conversions.h" 8 #include "base/strings/sys_string_conversions.h"
9 #import "chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest .h" 9 #import "chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest .h"
10 #import "chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.h" 10 #import "chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.h"
11 #import "chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.h" 11 #import "chrome/browser/ui/cocoa/applescript/bookmark_item_applescript.h"
12 #import "chrome/browser/ui/cocoa/applescript/constants_applescript.h" 12 #import "chrome/browser/ui/cocoa/applescript/constants_applescript.h"
13 #import "chrome/browser/ui/cocoa/applescript/error_applescript.h" 13 #import "chrome/browser/ui/cocoa/applescript/error_applescript.h"
14 #include "googleurl/src/gurl.h" 14 #include "googleurl/src/gurl.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 #import "testing/gtest_mac.h" 16 #import "testing/gtest_mac.h"
17 #include "testing/platform_test.h" 17 #include "testing/platform_test.h"
(...skipping 20 matching lines...) Expand all
38 EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty, 38 EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty,
39 [bookmarkFolder containerProperty]); 39 [bookmarkFolder containerProperty]);
40 } 40 }
41 } 41 }
42 42
43 // Insert a new bookmark folder. 43 // Insert a new bookmark folder.
44 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkFolder) { 44 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkFolder) {
45 // Emulate what applescript would do when inserting a new bookmark folder. 45 // Emulate what applescript would do when inserting a new bookmark folder.
46 // Emulates a script like |set var to make new bookmark folder with 46 // Emulates a script like |set var to make new bookmark folder with
47 // properties {title:"foo"}|. 47 // properties {title:"foo"}|.
48 scoped_nsobject<BookmarkFolderAppleScript> bookmarkFolder( 48 base::scoped_nsobject<BookmarkFolderAppleScript> bookmarkFolder(
49 [[BookmarkFolderAppleScript alloc] init]); 49 [[BookmarkFolderAppleScript alloc] init]);
50 scoped_nsobject<NSNumber> var([[bookmarkFolder.get() uniqueID] copy]); 50 base::scoped_nsobject<NSNumber> var([[bookmarkFolder.get() uniqueID] copy]);
51 [bookmarkFolder.get() setTitle:@"foo"]; 51 [bookmarkFolder.get() setTitle:@"foo"];
52 [bookmarkBar_.get() insertInBookmarkFolders:bookmarkFolder.get()]; 52 [bookmarkBar_.get() insertInBookmarkFolders:bookmarkFolder.get()];
53 53
54 // Represents the bookmark folder after it's added. 54 // Represents the bookmark folder after it's added.
55 BookmarkFolderAppleScript* bf = 55 BookmarkFolderAppleScript* bf =
56 [[bookmarkBar_.get() bookmarkFolders] objectAtIndex:2]; 56 [[bookmarkBar_.get() bookmarkFolders] objectAtIndex:2];
57 EXPECT_NSEQ(@"foo", [bf title]); 57 EXPECT_NSEQ(@"foo", [bf title]);
58 EXPECT_EQ([bf container], bookmarkBar_.get()); 58 EXPECT_EQ([bf container], bookmarkBar_.get());
59 EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty, 59 EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty,
60 [bf containerProperty]); 60 [bf containerProperty]);
61 EXPECT_NSEQ(var.get(), [bf uniqueID]); 61 EXPECT_NSEQ(var.get(), [bf uniqueID]);
62 } 62 }
63 63
64 // Insert a new bookmark folder at a particular position. 64 // Insert a new bookmark folder at a particular position.
65 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkFolderAtPosition) { 65 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkFolderAtPosition) {
66 // Emulate what applescript would do when inserting a new bookmark folder. 66 // Emulate what applescript would do when inserting a new bookmark folder.
67 // Emulates a script like |set var to make new bookmark folder with 67 // Emulates a script like |set var to make new bookmark folder with
68 // properties {title:"foo"} at after bookmark folder 1|. 68 // properties {title:"foo"} at after bookmark folder 1|.
69 scoped_nsobject<BookmarkFolderAppleScript> bookmarkFolder( 69 base::scoped_nsobject<BookmarkFolderAppleScript> bookmarkFolder(
70 [[BookmarkFolderAppleScript alloc] init]); 70 [[BookmarkFolderAppleScript alloc] init]);
71 scoped_nsobject<NSNumber> var([[bookmarkFolder.get() uniqueID] copy]); 71 base::scoped_nsobject<NSNumber> var([[bookmarkFolder.get() uniqueID] copy]);
72 [bookmarkFolder.get() setTitle:@"foo"]; 72 [bookmarkFolder.get() setTitle:@"foo"];
73 [bookmarkBar_.get() insertInBookmarkFolders:bookmarkFolder.get() atIndex:1]; 73 [bookmarkBar_.get() insertInBookmarkFolders:bookmarkFolder.get() atIndex:1];
74 74
75 // Represents the bookmark folder after it's added. 75 // Represents the bookmark folder after it's added.
76 BookmarkFolderAppleScript* bf = 76 BookmarkFolderAppleScript* bf =
77 [[bookmarkBar_.get() bookmarkFolders] objectAtIndex:1]; 77 [[bookmarkBar_.get() bookmarkFolders] objectAtIndex:1];
78 EXPECT_NSEQ(@"foo", [bf title]); 78 EXPECT_NSEQ(@"foo", [bf title]);
79 EXPECT_EQ([bf container], bookmarkBar_.get()); 79 EXPECT_EQ([bf container], bookmarkBar_.get());
80 EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty, [bf containerProperty]); 80 EXPECT_NSEQ(AppleScript::kBookmarkFoldersProperty, [bf containerProperty]);
81 EXPECT_NSEQ(var.get(), [bf uniqueID]); 81 EXPECT_NSEQ(var.get(), [bf uniqueID]);
(...skipping 30 matching lines...) Expand all
112 EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, 112 EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty,
113 [bookmarkItem containerProperty]); 113 [bookmarkItem containerProperty]);
114 } 114 }
115 } 115 }
116 116
117 // Insert a new bookmark item. 117 // Insert a new bookmark item.
118 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkItem) { 118 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkItem) {
119 // Emulate what applescript would do when inserting a new bookmark folder. 119 // Emulate what applescript would do when inserting a new bookmark folder.
120 // Emulates a script like |set var to make new bookmark item with 120 // Emulates a script like |set var to make new bookmark item with
121 // properties {title:"Google", URL:"http://google.com"}|. 121 // properties {title:"Google", URL:"http://google.com"}|.
122 scoped_nsobject<BookmarkItemAppleScript> bookmarkItem( 122 base::scoped_nsobject<BookmarkItemAppleScript> bookmarkItem(
123 [[BookmarkItemAppleScript alloc] init]); 123 [[BookmarkItemAppleScript alloc] init]);
124 scoped_nsobject<NSNumber> var([[bookmarkItem.get() uniqueID] copy]); 124 base::scoped_nsobject<NSNumber> var([[bookmarkItem.get() uniqueID] copy]);
125 [bookmarkItem.get() setTitle:@"Google"]; 125 [bookmarkItem.get() setTitle:@"Google"];
126 [bookmarkItem.get() setURL:@"http://google.com"]; 126 [bookmarkItem.get() setURL:@"http://google.com"];
127 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get()]; 127 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get()];
128 128
129 // Represents the bookmark item after it's added. 129 // Represents the bookmark item after it's added.
130 BookmarkItemAppleScript* bi = 130 BookmarkItemAppleScript* bi =
131 [[bookmarkBar_.get() bookmarkItems] objectAtIndex:3]; 131 [[bookmarkBar_.get() bookmarkItems] objectAtIndex:3];
132 EXPECT_NSEQ(@"Google", [bi title]); 132 EXPECT_NSEQ(@"Google", [bi title]);
133 EXPECT_EQ(GURL("http://google.com/"), 133 EXPECT_EQ(GURL("http://google.com/"),
134 GURL(base::SysNSStringToUTF8([bi URL]))); 134 GURL(base::SysNSStringToUTF8([bi URL])));
135 EXPECT_EQ([bi container], bookmarkBar_.get()); 135 EXPECT_EQ([bi container], bookmarkBar_.get());
136 EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, [bi containerProperty]); 136 EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, [bi containerProperty]);
137 EXPECT_NSEQ(var.get(), [bi uniqueID]); 137 EXPECT_NSEQ(var.get(), [bi uniqueID]);
138 138
139 // Test to see no bookmark item is created when no/invlid URL is entered. 139 // Test to see no bookmark item is created when no/invlid URL is entered.
140 scoped_nsobject<FakeScriptCommand> fakeScriptCommand( 140 base::scoped_nsobject<FakeScriptCommand> fakeScriptCommand(
141 [[FakeScriptCommand alloc] init]); 141 [[FakeScriptCommand alloc] init]);
142 bookmarkItem.reset([[BookmarkItemAppleScript alloc] init]); 142 bookmarkItem.reset([[BookmarkItemAppleScript alloc] init]);
143 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get()]; 143 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get()];
144 EXPECT_EQ((int)AppleScript::errInvalidURL, 144 EXPECT_EQ((int)AppleScript::errInvalidURL,
145 [fakeScriptCommand.get() scriptErrorNumber]); 145 [fakeScriptCommand.get() scriptErrorNumber]);
146 } 146 }
147 147
148 // Insert a new bookmark item at a particular position. 148 // Insert a new bookmark item at a particular position.
149 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkItemAtPosition) { 149 TEST_F(BookmarkFolderAppleScriptTest, InsertBookmarkItemAtPosition) {
150 // Emulate what applescript would do when inserting a new bookmark item. 150 // Emulate what applescript would do when inserting a new bookmark item.
151 // Emulates a script like |set var to make new bookmark item with 151 // Emulates a script like |set var to make new bookmark item with
152 // properties {title:"XKCD", URL:"http://xkcd.org} 152 // properties {title:"XKCD", URL:"http://xkcd.org}
153 // at after bookmark item 1|. 153 // at after bookmark item 1|.
154 scoped_nsobject<BookmarkItemAppleScript> bookmarkItem( 154 base::scoped_nsobject<BookmarkItemAppleScript> bookmarkItem(
155 [[BookmarkItemAppleScript alloc] init]); 155 [[BookmarkItemAppleScript alloc] init]);
156 scoped_nsobject<NSNumber> var([[bookmarkItem.get() uniqueID] copy]); 156 base::scoped_nsobject<NSNumber> var([[bookmarkItem.get() uniqueID] copy]);
157 [bookmarkItem.get() setTitle:@"XKCD"]; 157 [bookmarkItem.get() setTitle:@"XKCD"];
158 [bookmarkItem.get() setURL:@"http://xkcd.org"]; 158 [bookmarkItem.get() setURL:@"http://xkcd.org"];
159 159
160 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get() atIndex:1]; 160 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get() atIndex:1];
161 161
162 // Represents the bookmark item after its added. 162 // Represents the bookmark item after its added.
163 BookmarkItemAppleScript* bi = 163 BookmarkItemAppleScript* bi =
164 [[bookmarkBar_.get() bookmarkItems] objectAtIndex:1]; 164 [[bookmarkBar_.get() bookmarkItems] objectAtIndex:1];
165 EXPECT_NSEQ(@"XKCD", [bi title]); 165 EXPECT_NSEQ(@"XKCD", [bi title]);
166 EXPECT_EQ(GURL("http://xkcd.org/"), 166 EXPECT_EQ(GURL("http://xkcd.org/"),
167 GURL(base::SysNSStringToUTF8([bi URL]))); 167 GURL(base::SysNSStringToUTF8([bi URL])));
168 EXPECT_EQ([bi container], bookmarkBar_.get()); 168 EXPECT_EQ([bi container], bookmarkBar_.get());
169 EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty, 169 EXPECT_NSEQ(AppleScript::kBookmarkItemsProperty,
170 [bi containerProperty]); 170 [bi containerProperty]);
171 EXPECT_NSEQ(var.get(), [bi uniqueID]); 171 EXPECT_NSEQ(var.get(), [bi uniqueID]);
172 172
173 // Test to see no bookmark item is created when no/invlid URL is entered. 173 // Test to see no bookmark item is created when no/invlid URL is entered.
174 scoped_nsobject<FakeScriptCommand> fakeScriptCommand( 174 base::scoped_nsobject<FakeScriptCommand> fakeScriptCommand(
175 [[FakeScriptCommand alloc] init]); 175 [[FakeScriptCommand alloc] init]);
176 bookmarkItem.reset([[BookmarkItemAppleScript alloc] init]); 176 bookmarkItem.reset([[BookmarkItemAppleScript alloc] init]);
177 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get() atIndex:1]; 177 [bookmarkBar_.get() insertInBookmarkItems:bookmarkItem.get() atIndex:1];
178 EXPECT_EQ((int)AppleScript::errInvalidURL, 178 EXPECT_EQ((int)AppleScript::errInvalidURL,
179 [fakeScriptCommand.get() scriptErrorNumber]); 179 [fakeScriptCommand.get() scriptErrorNumber]);
180 } 180 }
181 181
182 // Delete bookmark items. 182 // Delete bookmark items.
183 TEST_F(BookmarkFolderAppleScriptTest, DeleteBookmarkItems) { 183 TEST_F(BookmarkFolderAppleScriptTest, DeleteBookmarkItems) {
184 unsigned int folderCount = 2, itemCount = 3; 184 unsigned int folderCount = 2, itemCount = 3;
185 for (unsigned int i = 0; i < itemCount; ++i) { 185 for (unsigned int i = 0; i < itemCount; ++i) {
186 EXPECT_EQ(folderCount, [[bookmarkBar_.get() bookmarkFolders] count]); 186 EXPECT_EQ(folderCount, [[bookmarkBar_.get() bookmarkFolders] count]);
187 EXPECT_EQ(itemCount - i, [[bookmarkBar_.get() bookmarkItems] count]); 187 EXPECT_EQ(itemCount - i, [[bookmarkBar_.get() bookmarkItems] count]);
188 [bookmarkBar_.get() removeFromBookmarkItemsAtIndex:0]; 188 [bookmarkBar_.get() removeFromBookmarkItemsAtIndex:0];
189 } 189 }
190 } 190 }
191 191
192 // Set and get title. 192 // Set and get title.
193 TEST_F(BookmarkFolderAppleScriptTest, GetAndSetTitle) { 193 TEST_F(BookmarkFolderAppleScriptTest, GetAndSetTitle) {
194 NSArray* bookmarkFolders = [bookmarkBar_.get() bookmarkFolders]; 194 NSArray* bookmarkFolders = [bookmarkBar_.get() bookmarkFolders];
195 BookmarkFolderAppleScript* folder1 = [bookmarkFolders objectAtIndex:0]; 195 BookmarkFolderAppleScript* folder1 = [bookmarkFolders objectAtIndex:0];
196 [folder1 setTitle:@"Foo"]; 196 [folder1 setTitle:@"Foo"];
197 EXPECT_NSEQ(@"Foo", [folder1 title]); 197 EXPECT_NSEQ(@"Foo", [folder1 title]);
198 } 198 }
199 199
200 } // namespace 200 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698