Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

Issue 17593006: mac: Update clients of scoped_nsobject.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: iwyu, scoped_nsprotocol Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "base/memory/scoped_nsobject.h" 5 #import "base/mac/scoped_nsobject.h"
6 #include "base/strings/string16.h" 6 #include "base/strings/string16.h"
7 #include "chrome/browser/bookmarks/bookmark_model.h" 7 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/bookmarks/bookmark_utils.h" 9 #include "chrome/browser/bookmarks/bookmark_utils.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h" 11 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"
12 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h" 12 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 @interface FakeBookmarkMenuController : BookmarkMenuCocoaController { 15 @interface FakeBookmarkMenuController : BookmarkMenuCocoaController {
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 CocoaProfileTest::SetUp(); 69 CocoaProfileTest::SetUp();
70 ASSERT_TRUE(profile()); 70 ASSERT_TRUE(profile());
71 71
72 controller_.reset( 72 controller_.reset(
73 [[FakeBookmarkMenuController alloc] initWithProfile:profile()]); 73 [[FakeBookmarkMenuController alloc] initWithProfile:profile()]);
74 } 74 }
75 75
76 FakeBookmarkMenuController* controller() { return controller_.get(); } 76 FakeBookmarkMenuController* controller() { return controller_.get(); }
77 77
78 private: 78 private:
79 scoped_nsobject<FakeBookmarkMenuController> controller_; 79 base::scoped_nsobject<FakeBookmarkMenuController> controller_;
80 }; 80 };
81 81
82 TEST_F(BookmarkMenuCocoaControllerTest, TestOpenItem) { 82 TEST_F(BookmarkMenuCocoaControllerTest, TestOpenItem) {
83 FakeBookmarkMenuController* c = controller(); 83 FakeBookmarkMenuController* c = controller();
84 NSMenuItem *item = [[[NSMenuItem alloc] init] autorelease]; 84 NSMenuItem *item = [[[NSMenuItem alloc] init] autorelease];
85 for (int i = 0; i < 2; i++) { 85 for (int i = 0; i < 2; i++) {
86 [item setTag:i]; 86 [item setTag:i];
87 ASSERT_EQ(c->opened_[i], NO); 87 ASSERT_EQ(c->opened_[i], NO);
88 [c openBookmarkMenuItem:item]; 88 [c openBookmarkMenuItem:item];
89 ASSERT_NE(c->opened_[i], NO); 89 ASSERT_NE(c->opened_[i], NO);
90 } 90 }
91 91
92 // Test three versions of 'Open All Bookmarks' item. tag id means nothing. 92 // Test three versions of 'Open All Bookmarks' item. tag id means nothing.
93 // I just reset the tag id to zero. 93 // I just reset the tag id to zero.
94 [item setTag:0]; 94 [item setTag:0];
95 EXPECT_EQ(c->opened_new_foreground_tab, NO); 95 EXPECT_EQ(c->opened_new_foreground_tab, NO);
96 [c openAllBookmarks:item]; 96 [c openAllBookmarks:item];
97 EXPECT_NE(c->opened_new_foreground_tab, NO); 97 EXPECT_NE(c->opened_new_foreground_tab, NO);
98 98
99 EXPECT_EQ(c->opened_new_window, NO); 99 EXPECT_EQ(c->opened_new_window, NO);
100 [c openAllBookmarksNewWindow:item]; 100 [c openAllBookmarksNewWindow:item];
101 EXPECT_NE(c->opened_new_window, NO); 101 EXPECT_NE(c->opened_new_window, NO);
102 102
103 EXPECT_EQ(c->opened_off_the_record, NO); 103 EXPECT_EQ(c->opened_off_the_record, NO);
104 [c openAllBookmarksIncognitoWindow:item]; 104 [c openAllBookmarksIncognitoWindow:item];
105 EXPECT_NE(c->opened_off_the_record, NO); 105 EXPECT_NE(c->opened_off_the_record, NO);
106 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698