chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 17593006: mac: Update clients of scoped_nsobject.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 17593006: mac: Update clients of scoped_nsobject.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: iwyu, scoped_nsprotocol Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 3c43a3704be42d5a27440ae0848912942db95ff2..d9f3890a0fd7c0badfe471189545a51e9b384f91 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -1073,8 +1073,8 @@ void RecordAppLaunch(Profile* profile, GURL url) {

BookmarkButtonCell* cell = [self cellForBookmarkNode:node];

NSRect frame = [self frameForBookmarkButtonFromCell:cell xOffset:xOffset];

- scoped_nsobject<BookmarkButton>

- button([[BookmarkButton alloc] initWithFrame:frame]);

+ base::scoped_nsobject<BookmarkButton> button(

+ [[BookmarkButton alloc] initWithFrame:frame]);

DCHECK(button.get());

// [NSButton setCell:] warns to NOT use setCell: other than in the