Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: content/common/mac/font_loader.mm

Issue 17593006: mac: Update clients of scoped_nsobject.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: iwyu, scoped_nsprotocol Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/mac/font_loader.h" 5 #include "content/common/mac/font_loader.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 #include "base/mac/foundation_util.h" 13 #include "base/mac/foundation_util.h"
14 #include "base/mac/mac_util.h" 14 #include "base/mac/mac_util.h"
15 #include "base/mac/scoped_cftyperef.h" 15 #include "base/mac/scoped_cftyperef.h"
16 #include "base/memory/scoped_nsobject.h" 16 #include "base/mac/scoped_nsobject.h"
17 #include "base/strings/sys_string_conversions.h" 17 #include "base/strings/sys_string_conversions.h"
18 #include "base/threading/thread_restrictions.h" 18 #include "base/threading/thread_restrictions.h"
19 #include "content/common/mac/font_descriptor.h" 19 #include "content/common/mac/font_descriptor.h"
20 20
21 #include <map> 21 #include <map>
22 22
23 extern "C" { 23 extern "C" {
24 24
25 // Work around http://crbug.com/93191, a really nasty memory smasher bug. 25 // Work around http://crbug.com/93191, a really nasty memory smasher bug.
26 // On Mac OS X 10.7 ("Lion"), ATS writes to memory it doesn't own. 26 // On Mac OS X 10.7 ("Lion"), ATS writes to memory it doesn't own.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 105
106 // NSFont -> File path. 106 // NSFont -> File path.
107 // Warning: Calling this function on a font activated from memory will result 107 // Warning: Calling this function on a font activated from memory will result
108 // in failure with a -50 - paramErr. This may occur if 108 // in failure with a -50 - paramErr. This may occur if
109 // CreateCGFontFromBuffer() is called in the same process as this function 109 // CreateCGFontFromBuffer() is called in the same process as this function
110 // e.g. when writing a unit test that exercises these two functions together. 110 // e.g. when writing a unit test that exercises these two functions together.
111 // If said unit test were to load a system font and activate it from memory 111 // If said unit test were to load a system font and activate it from memory
112 // it becomes impossible for the system to the find the original file ref 112 // it becomes impossible for the system to the find the original file ref
113 // since the font now lives in memory as far as it's concerned. 113 // since the font now lives in memory as far as it's concerned.
114 CTFontRef ct_font_to_encode = (CTFontRef)font_to_encode; 114 CTFontRef ct_font_to_encode = (CTFontRef)font_to_encode;
115 scoped_nsobject<NSURL> font_url( 115 base::scoped_nsobject<NSURL> font_url(
116 base::mac::CFToNSCast(base::mac::CFCastStrict<CFURLRef>( 116 base::mac::CFToNSCast(base::mac::CFCastStrict<CFURLRef>(
117 CTFontCopyAttribute(ct_font_to_encode, kCTFontURLAttribute)))); 117 CTFontCopyAttribute(ct_font_to_encode, kCTFontURLAttribute))));
118 if (![font_url isFileURL]) { 118 if (![font_url isFileURL]) {
119 DLOG(ERROR) << "Failed to find font file for " << font_name; 119 DLOG(ERROR) << "Failed to find font file for " << font_name;
120 return; 120 return;
121 } 121 }
122 122
123 base::FilePath font_path = base::mac::NSStringToFilePath([font_url path]); 123 base::FilePath font_path = base::mac::NSStringToFilePath([font_url path]);
124 124
125 // Load file into shared memory buffer. 125 // Load file into shared memory buffer.
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 if (!provider) 173 if (!provider)
174 return false; 174 return false;
175 175
176 *out = CGFontCreateWithDataProvider(provider.get()); 176 *out = CGFontCreateWithDataProvider(provider.get());
177 177
178 if (*out == NULL) 178 if (*out == NULL)
179 return false; 179 return false;
180 180
181 return true; 181 return true;
182 } 182 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698