Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1751863002: [serializer] split up src/snapshot/serialize.* (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] split up src/snapshot/serialize.* R=rossberg@chromium.org, ulan@chromium.org, vogelheim@chromium.org Committed: https://crrev.com/6f17848caa6eb2658bf0e9eb262b060713d32878 Cr-Commit-Position: refs/heads/master@{#34395}

Patch Set 1 #

Patch Set 2 : fix build.gn #

Total comments: 1

Patch Set 3 : addressed comment #

Patch Set 4 : rebase #

Patch Set 5 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4026 lines, -3947 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/collector.h View 1 2 1 chunk +247 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/parsing/preparse-data.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
A src/snapshot/code-serializer.h View 1 chunk +127 lines, -0 lines 0 comments Download
A src/snapshot/code-serializer.cc View 1 2 3 1 chunk +418 lines, -0 lines 0 comments Download
A src/snapshot/deserializer.h View 1 chunk +140 lines, -0 lines 0 comments Download
A src/snapshot/deserializer.cc View 1 chunk +810 lines, -0 lines 1 comment Download
M src/snapshot/mksnapshot.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A src/snapshot/partial-serializer.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/snapshot/partial-serializer.cc View 1 chunk +128 lines, -0 lines 0 comments Download
D src/snapshot/serialize.h View 1 chunk +0 lines, -816 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 3 4 1 chunk +0 lines, -2874 lines 0 comments Download
A src/snapshot/serializer.h View 1 chunk +321 lines, -0 lines 0 comments Download
A src/snapshot/serializer.cc View 1 chunk +769 lines, -0 lines 0 comments Download
A src/snapshot/serializer-common.h View 1 chunk +322 lines, -0 lines 0 comments Download
A src/snapshot/serializer-common.cc View 1 chunk +375 lines, -0 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +37 lines, -1 line 0 comments Download
M src/snapshot/snapshot-common.cc View 2 chunks +50 lines, -0 lines 0 comments Download
M src/snapshot/snapshot-external.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/snapshot/snapshot-source-sink.cc View 1 chunk +0 lines, -1 line 0 comments Download
A src/snapshot/startup-serializer.h View 1 chunk +41 lines, -0 lines 0 comments Download
A src/snapshot/startup-serializer.cc View 1 chunk +132 lines, -0 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -234 lines 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/external-reference-check.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (11 generated)
Yang
4 years, 9 months ago (2016-03-01 12:20:05 UTC) #1
Yang
On 2016/03/01 12:20:05, Yang wrote: This is a pure refactoring CL aside from fixing includes.
4 years, 9 months ago (2016-03-01 12:20:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751863002/1
4 years, 9 months ago (2016-03-01 12:20:47 UTC) #4
rossberg
LGTM (rubber stamp)
4 years, 9 months ago (2016-03-01 12:22:33 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/14323)
4 years, 9 months ago (2016-03-01 12:28:14 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751863002/20001
4 years, 9 months ago (2016-03-01 12:36:39 UTC) #9
vogelheim
lgtm https://codereview.chromium.org/1751863002/diff/20001/src/collector.h File src/collector.h (right): https://codereview.chromium.org/1751863002/diff/20001/src/collector.h#newcode8 src/collector.h:8: #include "src/list.h" Also src/vector.h? Also src/checks.h? (for DCHECK ...
4 years, 9 months ago (2016-03-01 12:50:03 UTC) #10
ulan
heap lgtm
4 years, 9 months ago (2016-03-01 13:14:48 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 13:18:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751863002/40001
4 years, 9 months ago (2016-03-01 13:50:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/13027)
4 years, 9 months ago (2016-03-01 14:10:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751863002/80001
4 years, 9 months ago (2016-03-01 14:21:04 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-01 14:43:03 UTC) #22
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/6f17848caa6eb2658bf0e9eb262b060713d32878 Cr-Commit-Position: refs/heads/master@{#34395}
4 years, 9 months ago (2016-03-01 14:44:18 UTC) #24
Michael Achenbach
https://codereview.chromium.org/1751863002/diff/80001/src/snapshot/deserializer.cc File src/snapshot/deserializer.cc (right): https://codereview.chromium.org/1751863002/diff/80001/src/snapshot/deserializer.cc#newcode1 src/snapshot/deserializer.cc:1: // Copyright 2016 the V8 project authors. All rights ...
4 years, 9 months ago (2016-03-01 20:02:03 UTC) #26
yangguo
On 2016/03/01 20:02:03, Michael Achenbach wrote: > https://codereview.chromium.org/1751863002/diff/80001/src/snapshot/deserializer.cc > File src/snapshot/deserializer.cc (right): > > https://codereview.chromium.org/1751863002/diff/80001/src/snapshot/deserializer.cc#newcode1 ...
4 years, 9 months ago (2016-03-01 20:06:41 UTC) #27
Michael Hablich
On 2016/03/01 20:06:41, yangguo wrote: > On 2016/03/01 20:02:03, Michael Achenbach wrote: > > > ...
4 years, 9 months ago (2016-03-01 20:12:19 UTC) #28
Michael Hablich
4 years, 9 months ago (2016-03-01 20:18:14 UTC) #29
Message was sent while issue was closed. 
Would it make sense to add this license check to our CQ?

Powered by Google App Engine
This is Rietveld 408576698