Use v8::MicrotasksScope internally in V8RecursionScope.

Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #3.
First one broke GinJavaBridgeValueConverterTest.TypedArrays.
Second one broke FileManagerBrowserTest family on ChromeOS.

BUG=585949
Committed: https://crrev.com/fdfd5d17ab08e528799125a242893f6f5dcbea43
Cr-Commit-Position: refs/heads/master@{#380570}

[dgozman, 2016-02-27 03:06:10]

dgozman@chromium.org changed reviewers:
+ adamk@chromium.org, jochen@chromium.org

[dgozman, 2016-02-27 03:06:10]

Could you please take a look?

V8-side patch: https://codereview.chromium.org/1741893003/

Thanks,
Dmitry

[jochen (gone - plz use gerrit), 2016-03-03 06:36:06]

lgtm

[dgozman, 2016-03-06 23:55:09]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-06 23:55:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/20001

[commit-bot: I haz the power, 2016-03-07 00:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 00:34:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-07 01:59:55]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 02:00:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/40001

[commit-bot: I haz the power, 2016-03-07 03:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 03:19:32]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-03-07 15:31:45]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 15:31:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/80001

[commit-bot: I haz the power, 2016-03-07 17:20:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 17:20:25]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-03-07 17:21:56]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-07 17:21:57]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1743763004/#ps80001
(title: "even more unit tests")

[commit-bot: I haz the power, 2016-03-07 17:22:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/80001

[commit-bot: I haz the power, 2016-03-07 17:28:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-07 17:29:59]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

BUG=585949
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

BUG=585949

Committed: https://crrev.com/83013584d091473d3a5fee6a823bc63b223a472c
Cr-Commit-Position: refs/heads/master@{#379574}
==========

[commit-bot: I haz the power, 2016-03-07 17:30:02]

Patchset 5 (id:??) landed as
https://crrev.com/83013584d091473d3a5fee6a823bc63b223a472c
Cr-Commit-Position: refs/heads/master@{#379574}

[nyquist, 2016-03-08 08:00:22]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1765423004/ by nyquist@chromium.org.

The reason for reverting is: Causes content_unittests to fail on
GinJavaBridgeValueConverterTest.TypedArrays for Android on a bunch of testers:
Marshmallow Tablet Tester -
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%...
Marshmallow 64 bit Tester -
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%...
Lollipop Tablet Tester -
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20T...
Lollipop Phone Tester -
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20P...
Lollipop Low-end Tester -
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20L...

git bisect succesfully identified this CL as the culprit:
83013584d091473d3a5fee6a823bc63b223a472c is the first bad commit

See http://crbug.com/592906 for details..

[dgozman, 2016-03-08 18:53:03]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

BUG=585949

Committed: https://crrev.com/83013584d091473d3a5fee6a823bc63b223a472c
Cr-Commit-Position: refs/heads/master@{#379574}
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.

BUG=585949
==========

[dgozman, 2016-03-09 00:18:32]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-09 00:18:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1743763004/#ps100001
(title: "GinJavaBridgeValueConverterTest")

[commit-bot: I haz the power, 2016-03-09 00:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/100001

[commit-bot: I haz the power, 2016-03-09 02:15:01]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.

BUG=585949
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.

BUG=585949
==========

[commit-bot: I haz the power, 2016-03-09 02:15:02]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-09 02:16:22]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.

BUG=585949
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.

BUG=585949

Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
Cr-Commit-Position: refs/heads/master@{#380033}
==========

[commit-bot: I haz the power, 2016-03-09 02:16:23]

Patchset 6 (id:??) landed as
https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
Cr-Commit-Position: refs/heads/master@{#380033}

[tsergeant, 2016-03-10 02:54:22]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1777183002/ by tsergeant@chromium.org.

The reason for reverting is: This CL appears to be causing test failures on
Linux ChromiumOS Tests (dbg)(1).

See:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Tests are failing with:
Fatal error in ../../v8/src/api.cc, line 166
Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() ||
!handle_scope_implementer->DebugMicrotasksScopeDepthIsZero().

[dgozman, 2016-03-10 18:46:34]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.

BUG=585949

Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
Cr-Commit-Position: refs/heads/master@{#380033}
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #3.
First one broke GinJavaBridgeValueConverterTest.TypedArrays.
Second one broke FileManagerBrowserTest family on ChromeOS.

BUG=585949
==========

[dgozman, 2016-03-10 18:48:41]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-10 18:48:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1743763004/#ps120001
(title: "v8_helpers")

[commit-bot: I haz the power, 2016-03-10 18:49:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/120001

[commit-bot: I haz the power, 2016-03-10 20:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 20:10:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-10 21:42:53]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:43:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/120001

[commit-bot: I haz the power, 2016-03-10 23:42:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:42:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-11 02:30:34]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-11 02:31:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/120001

[commit-bot: I haz the power, 2016-03-11 02:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 02:45:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-03-11 02:48:23]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-11 02:48:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/120001

[commit-bot: I haz the power, 2016-03-11 03:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 03:00:59]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-03-11 06:20:06]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-11 06:20:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743763004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743763004/120001

[commit-bot: I haz the power, 2016-03-11 07:50:55]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #3.
First one broke GinJavaBridgeValueConverterTest.TypedArrays.
Second one broke FileManagerBrowserTest family on ChromeOS.

BUG=585949
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #3.
First one broke GinJavaBridgeValueConverterTest.TypedArrays.
Second one broke FileManagerBrowserTest family on ChromeOS.

BUG=585949
==========

[commit-bot: I haz the power, 2016-03-11 07:50:58]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-11 07:53:14]

Description was changed from

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #3.
First one broke GinJavaBridgeValueConverterTest.TypedArrays.
Second one broke FileManagerBrowserTest family on ChromeOS.

BUG=585949
==========

to

==========
Use v8::MicrotasksScope internally in V8RecursionScope.

If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
along with other cleanups.

Attempt #3.
First one broke GinJavaBridgeValueConverterTest.TypedArrays.
Second one broke FileManagerBrowserTest family on ChromeOS.

BUG=585949

Committed: https://crrev.com/fdfd5d17ab08e528799125a242893f6f5dcbea43
Cr-Commit-Position: refs/heads/master@{#380570}
==========

[commit-bot: I haz the power, 2016-03-11 07:53:16]

Patchset 7 (id:??) landed as
https://crrev.com/fdfd5d17ab08e528799125a242893f6f5dcbea43
Cr-Commit-Position: refs/heads/master@{#380570}