Created Revert of Use v8::MicrotasksScope internally in V8RecursionScope.
4 years, 9 months ago
(2016-03-10 02:54:23 UTC)
#1
Created Revert of Use v8::MicrotasksScope internally in V8RecursionScope.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777183002/1
4 years, 9 months ago
(2016-03-10 02:54:53 UTC)
#2
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/142910) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago
(2016-03-10 02:57:24 UTC)
#4
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777183002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777183002/270001
4 years, 9 months ago
(2016-03-10 03:33:26 UTC)
#6
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194349)
4 years, 9 months ago
(2016-03-10 05:07:20 UTC)
#8
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777183002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777183002/270001
4 years, 9 months ago
(2016-03-10 05:18:18 UTC)
#10
Description was changed from ========== Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6 id:100001 ...
4 years, 9 months ago
(2016-03-10 06:20:52 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6
id:100001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1).
See:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
Tests are failing with:
Fatal error in ../../v8/src/api.cc, line 166
Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() ||
!handle_scope_implementer->DebugMicrotasksScopeDepthIsZero()
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.
>
> BUG=585949
>
> Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
> Cr-Commit-Position: refs/heads/master@{#380033}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585949
==========
to
==========
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6
id:100001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1).
See:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
Tests are failing with:
Fatal error in ../../v8/src/api.cc, line 166
Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() ||
!handle_scope_implementer->DebugMicrotasksScopeDepthIsZero()
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.
>
> BUG=585949
>
> Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
> Cr-Commit-Position: refs/heads/master@{#380033}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585949
==========
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years, 9 months ago
(2016-03-10 06:20:53 UTC)
#12
Message was sent while issue was closed.
Committed patchset #2 (id:270001)
commit-bot: I haz the power
Description was changed from ========== Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6 id:100001 ...
4 years, 9 months ago
(2016-03-10 06:22:10 UTC)
#13
Message was sent while issue was closed.
Description was changed from
==========
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6
id:100001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1).
See:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
Tests are failing with:
Fatal error in ../../v8/src/api.cc, line 166
Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() ||
!handle_scope_implementer->DebugMicrotasksScopeDepthIsZero()
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.
>
> BUG=585949
>
> Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
> Cr-Commit-Position: refs/heads/master@{#380033}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585949
==========
to
==========
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6
id:100001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1).
See:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
Tests are failing with:
Fatal error in ../../v8/src/api.cc, line 166
Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() ||
!handle_scope_implementer->DebugMicrotasksScopeDepthIsZero()
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and
WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.
>
> BUG=585949
>
> Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
> Cr-Commit-Position: refs/heads/master@{#380033}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585949
Committed: https://crrev.com/34828570d298a402b6964cdfa99521c74c507faa
Cr-Commit-Position: refs/heads/master@{#380356}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/34828570d298a402b6964cdfa99521c74c507faa Cr-Commit-Position: refs/heads/master@{#380356}
4 years, 9 months ago
(2016-03-10 06:22:11 UTC)
#14
Issue 1777183002: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.
(Closed)
Created 4 years, 9 months ago by tsergeant
Modified 4 years, 9 months ago
Reviewers: jochen (gone - plz use gerrit), adamk, dgozman
Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope
Comments: 0