Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1777183002: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed)

Created:
4 years, 9 months ago by tsergeant
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6 id:100001 of https://codereview.chromium.org/1743763004/ ) Reason for revert: This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1). See: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/12424 Tests are failing with: Fatal error in ../../v8/src/api.cc, line 166 Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() || !handle_scope_implementer->DebugMicrotasksScopeDepthIsZero() Original issue's description: > Use v8::MicrotasksScope internally in V8RecursionScope. > > If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression, > along with other cleanups. > > Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays. > > BUG=585949 > > Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463 > Cr-Commit-Position: refs/heads/master@{#380033} TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585949 Committed: https://crrev.com/34828570d298a402b6964cdfa99521c74c507faa Cr-Commit-Position: refs/heads/master@{#380356}

Patch Set 1 #

Patch Set 2 : Resolve patch conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -108 lines) Patch
M chrome/test/base/v8_unit_test.cc View 1 4 chunks +0 lines, -4 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 1 8 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/safe_builtins.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gin/run_microtasks_observer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gin/run_microtasks_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp View 1 7 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp View 1 11 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 1 3 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 5 chunks +31 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h View 1 1 chunk +31 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Microtask.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamReaderTest.cpp View 1 21 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamTest.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
tsergeant
Created Revert of Use v8::MicrotasksScope internally in V8RecursionScope.
4 years, 9 months ago (2016-03-10 02:54:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777183002/1
4 years, 9 months ago (2016-03-10 02:54:53 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/142910) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-10 02:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777183002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777183002/270001
4 years, 9 months ago (2016-03-10 03:33:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194349)
4 years, 9 months ago (2016-03-10 05:07:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777183002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777183002/270001
4 years, 9 months ago (2016-03-10 05:18:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years, 9 months ago (2016-03-10 06:20:53 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 06:22:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34828570d298a402b6964cdfa99521c74c507faa
Cr-Commit-Position: refs/heads/master@{#380356}

Powered by Google App Engine
This is Rietveld 408576698