third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp - Issue 1743763004: Use v8::MicrotasksScope internally in V8RecursionScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

Issue 1743763004: Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: v8_helpers Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

index 4d19f764c81530f9aac54cf0feaffc44637f906f..00c3fa65fe120b6b47388bb3ff97abab91d61ef9 100644

--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

@@ -8,6 +8,7 @@

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/V8BindingMacros.h"

#include "bindings/core/v8/V8GCController.h"

+#include "bindings/core/v8/V8RecursionScope.h"

#include "core/dom/Document.h"

#include "core/testing/DummyPageHolder.h"

#include "modules/fetch/DataConsumerHandleTestUtil.h"

@@ -59,6 +60,7 @@ public:

{

v8::Local<v8::String> source;

v8::Local<v8::Script> script;

+ V8RecursionScope::MicrotaskSuppression microtasks(isolate());

if (!v8Call(v8::String::NewFromUtf8(isolate(), s, v8::NewStringType::kNormal), source)) {

ADD_FAILURE();

return v8::MaybeLocal<v8::Value>();