extensions/renderer/api_test_base.cc - Issue 1743763004: Use v8::MicrotasksScope internally in V8RecursionScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_test_base.cc

Issue 1743763004: Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: v8_helpers Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/api_test_base.cc

diff --git a/extensions/renderer/api_test_base.cc b/extensions/renderer/api_test_base.cc

index abf868b3a8c0f63b2b7e311281c9ebd8ec16c574..79f95e2771166aea25253e20827958392977a754 100644

--- a/extensions/renderer/api_test_base.cc

+++ b/extensions/renderer/api_test_base.cc

@@ -214,7 +214,7 @@ void ApiTestEnvironment::RunTestInner(const std::string& test_name,

}

void ApiTestEnvironment::RunPromisesAgain() {

- env()->isolate()->RunMicrotasks();

+ v8::MicrotasksScope::PerformCheckpoint(env()->isolate());

base::MessageLoop::current()->PostTask(

FROM_HERE, base::Bind(&ApiTestEnvironment::RunPromisesAgain,

base::Unretained(this)));

« no previous file with comments | « extensions/renderer/activity_log_converter_strategy_unittest.cc ('k') | extensions/renderer/module_system_test.cc » ('j') | no next file with comments »