Use v8::MicrotasksScope internally in V8RecursionScope.

third_party/WebKit/Source/core/streams/ReadableStreamReaderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/streams/ReadableStreamReader.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ToV8.h"
 #include "bindings/core/v8/V8ThrowException.h"
@@ skipping 161 matching lines @@
     EXPECT_TRUE(reader->isActive());
 
     reader->closed(getScriptState()).then(createCaptor(&onFulfilled), createCaptor(&onRejected));
     reader->releaseLock(exceptionState);
     EXPECT_FALSE(reader->isActive());
     EXPECT_FALSE(exceptionState.hadException());
 
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_TRUE(onRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_EQ("AbortError: the reader is already released", onRejected);
 
     ReadableStreamReader* another = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_TRUE(another->isActive());
     EXPECT_FALSE(reader->isActive());
     reader->releaseLock(exceptionState);
     EXPECT_TRUE(another->isActive());
     EXPECT_FALSE(reader->isActive());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, ReadAfterRelease)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_TRUE(reader->isActive());
     reader->releaseLock(exceptionState);
     EXPECT_FALSE(exceptionState.hadException());
     EXPECT_FALSE(reader->isActive());
 
     ReadResult result;
     String onRejected;
     reader->read(getScriptState()).then(createResultCaptor(&result), createCaptor(&onRejected));
 
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_FALSE(result.isSet);
     EXPECT_EQ("TypeError: the reader is already released", onRejected);
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, ReleaseShouldFailWhenCalledWhileReading)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
@@ skipping 21 matching lines @@
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     ReadResult result;
     String onRejected;
     reader->read(getScriptState()).then(createResultCaptor(&result), createCaptor(&onRejected));
 
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(result.isSet);
     EXPECT_FALSE(result.isDone);
     EXPECT_EQ("hello", result.valueString);
     EXPECT_TRUE(onRejected.isNull());
 
     ReadResult result2;
     String onRejected2;
     reader->read(getScriptState()).then(createResultCaptor(&result2), createCaptor(&onRejected2));
 
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(result2.isSet);
     EXPECT_FALSE(result2.isDone);
     EXPECT_EQ("world", result2.valueString);
     EXPECT_TRUE(onRejected2.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, ReadThenEnqueue)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     ReadResult result, result2;
     String onRejected, onRejected2;
     reader->read(getScriptState()).then(createResultCaptor(&result), createCaptor(&onRejected));
     reader->read(getScriptState()).then(createResultCaptor(&result2), createCaptor(&onRejected2));
 
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
     m_stream->enqueue("hello");
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(result.isSet);
     EXPECT_FALSE(result.isDone);
     EXPECT_EQ("hello", result.valueString);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
     m_stream->enqueue("world");
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(result2.isSet);
     EXPECT_FALSE(result2.isDone);
     EXPECT_EQ("world", result2.valueString);
     EXPECT_TRUE(onRejected2.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, ClosedReader)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
 
     m_stream->close();
 
     EXPECT_TRUE(reader->isActive());
 
     String onClosedFulfilled, onClosedRejected;
     ReadResult result;
     String onReadRejected;
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     reader->closed(getScriptState()).then(createCaptor(&onClosedFulfilled), createCaptor(&onClosedRejected));
     reader->read(getScriptState()).then(createResultCaptor(&result), createCaptor(&onReadRejected));
     EXPECT_TRUE(onClosedFulfilled.isNull());
     EXPECT_TRUE(onClosedRejected.isNull());
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onReadRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_EQ("undefined", onClosedFulfilled);
     EXPECT_TRUE(onClosedRejected.isNull());
     EXPECT_TRUE(result.isSet);
     EXPECT_TRUE(result.isDone);
     EXPECT_EQ("undefined", result.valueString);
     EXPECT_TRUE(onReadRejected.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, ErroredReader)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
 
     m_stream->error(DOMException::create(SyntaxError, "some error"));
 
     EXPECT_EQ(ReadableStream::Errored, m_stream->stateInternal());
     EXPECT_TRUE(reader->isActive());
 
     String onClosedFulfilled, onClosedRejected;
     String onReadFulfilled, onReadRejected;
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     reader->closed(getScriptState()).then(createCaptor(&onClosedFulfilled), createCaptor(&onClosedRejected));
     reader->read(getScriptState()).then(createCaptor(&onReadFulfilled), createCaptor(&onReadRejected));
     EXPECT_TRUE(onClosedFulfilled.isNull());
     EXPECT_TRUE(onClosedRejected.isNull());
     EXPECT_TRUE(onReadFulfilled.isNull());
     EXPECT_TRUE(onReadRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_TRUE(onClosedFulfilled.isNull());
     EXPECT_EQ("SyntaxError: some error", onClosedRejected);
     EXPECT_TRUE(onReadFulfilled.isNull());
     EXPECT_EQ("SyntaxError: some error", onReadRejected);
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, PendingReadsShouldBeResolvedWhenClosed)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     ReadResult result, result2;
     String onRejected, onRejected2;
     reader->read(getScriptState()).then(createResultCaptor(&result), createCaptor(&onRejected));
     reader->read(getScriptState()).then(createResultCaptor(&result2), createCaptor(&onRejected2));
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
     m_stream->close();
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(result.isSet);
     EXPECT_TRUE(result.isDone);
     EXPECT_EQ("undefined", result.valueString);
     EXPECT_TRUE(onRejected.isNull());
 
     EXPECT_TRUE(result2.isSet);
     EXPECT_TRUE(result2.isDone);
     EXPECT_EQ("undefined", result2.valueString);
     EXPECT_TRUE(onRejected2.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, PendingReadsShouldBeRejectedWhenErrored)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     String onFulfilled, onFulfilled2;
     String onRejected, onRejected2;
     reader->read(getScriptState()).then(createCaptor(&onFulfilled), createCaptor(&onRejected));
     reader->read(getScriptState()).then(createCaptor(&onFulfilled2), createCaptor(&onRejected2));
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_TRUE(onFulfilled2.isNull());
     EXPECT_TRUE(onRejected2.isNull());
 
     m_stream->error(DOMException::create(SyntaxError, "some error"));
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_TRUE(onFulfilled2.isNull());
     EXPECT_TRUE(onRejected2.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_EQ(onRejected, "SyntaxError: some error");
     EXPECT_TRUE(onFulfilled2.isNull());
     EXPECT_EQ(onRejected2, "SyntaxError: some error");
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, PendingReadsShouldBeResolvedWhenCanceled)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     ReadResult result, result2;
     String onRejected, onRejected2;
     reader->read(getScriptState()).then(createResultCaptor(&result), createCaptor(&onRejected));
     reader->read(getScriptState()).then(createResultCaptor(&result2), createCaptor(&onRejected2));
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
     reader->cancel(getScriptState(), ScriptValue(getScriptState(), v8::Undefined(isolate())));
     EXPECT_TRUE(reader->isActive());
     EXPECT_FALSE(result.isSet);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(result2.isSet);
     EXPECT_TRUE(onRejected2.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(result.isSet);
     EXPECT_TRUE(result.isDone);
     EXPECT_EQ("undefined", result.valueString);
     EXPECT_TRUE(onRejected.isNull());
 
     EXPECT_TRUE(result2.isSet);
     EXPECT_TRUE(result2.isDone);
     EXPECT_EQ("undefined", result2.valueString);
     EXPECT_TRUE(onRejected2.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, CancelShouldNotWorkWhenNotActive)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     reader->releaseLock(exceptionState);
     EXPECT_FALSE(reader->isActive());
 
     String onFulfilled, onRejected;
     reader->cancel(getScriptState(), ScriptValue(getScriptState(), v8::Undefined(isolate()))).then(createCaptor(&onFulfilled), createCaptor(&onRejected));
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_TRUE(onRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
 
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_EQ("TypeError: the reader is already released", onRejected);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, Cancel)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     String onClosedFulfilled, onClosedRejected;
     String onCancelFulfilled, onCancelRejected;
     reader->closed(getScriptState()).then(createCaptor(&onClosedFulfilled), createCaptor(&onClosedRejected));
     reader->cancel(getScriptState(), ScriptValue(getScriptState(), v8::Undefined(isolate()))).then(createCaptor(&onCancelFulfilled), createCaptor(&onCancelRejected));
 
     EXPECT_EQ(ReadableStream::Closed, m_stream->stateInternal());
     EXPECT_TRUE(onClosedFulfilled.isNull());
     EXPECT_TRUE(onClosedRejected.isNull());
     EXPECT_TRUE(onCancelFulfilled.isNull());
     EXPECT_TRUE(onCancelRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_EQ("undefined", onClosedFulfilled);
     EXPECT_TRUE(onClosedRejected.isNull());
     EXPECT_EQ("undefined", onCancelFulfilled);
     EXPECT_TRUE(onCancelRejected.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, Close)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     String onFulfilled, onRejected;
     reader->closed(getScriptState()).then(createCaptor(&onFulfilled), createCaptor(&onRejected));
 
     m_stream->close();
 
     EXPECT_EQ(ReadableStream::Closed, m_stream->stateInternal());
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_TRUE(onRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_EQ("undefined", onFulfilled);
     EXPECT_TRUE(onRejected.isNull());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 TEST_F(ReadableStreamReaderTest, Error)
 {
     ScriptState::Scope scope(getScriptState());
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "property", "interface", getScriptState()->context()->Global(), isolate());
     ReadableStreamReader* reader = new ReadableStreamReader(getExecutionContext(), m_stream);
     EXPECT_EQ(ReadableStream::Readable, m_stream->stateInternal());
 
     String onFulfilled, onRejected;
     reader->closed(getScriptState()).then(createCaptor(&onFulfilled), createCaptor(&onRejected));
 
     m_stream->error(DOMException::create(SyntaxError, "some error"));
 
     EXPECT_EQ(ReadableStream::Errored, m_stream->stateInternal());
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_TRUE(onRejected.isNull());
 
-    isolate()->RunMicrotasks();
+    v8::MicrotasksScope::PerformCheckpoint(isolate());
     EXPECT_TRUE(onFulfilled.isNull());
     EXPECT_EQ("SyntaxError: some error", onRejected);
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 } // namespace
 
 } // namespace blink