Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 1743763004: Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope
Patch Set: v8_helpers Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 090fc85695f34eb6a7689dcf6ff0dba242b3cbd2..2cda3f4ed178432aabcb1f1a4c6f82699d53d08a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -74,31 +74,18 @@ public:
static void enableIdleTasks(v8::Isolate*, PassOwnPtr<gin::V8IdleTaskRunner>);
- bool destructionPending() const { return m_destructionPending; }
v8::Isolate* isolate() { return m_isolateHolder->isolate(); }
StringCache* getStringCache() { return m_stringCache.get(); }
v8::Persistent<v8::Value>& ensureLiveRoot();
- int recursionLevel() const { return m_recursionLevel; }
- int incrementRecursionLevel() { return ++m_recursionLevel; }
- int decrementRecursionLevel() { return --m_recursionLevel; }
bool isHandlingRecursionLevelError() const { return m_isHandlingRecursionLevelError; }
void setIsHandlingRecursionLevelError(bool value) { m_isHandlingRecursionLevelError = value; }
bool isReportingException() const { return m_isReportingException; }
void setReportingException(bool value) { m_isReportingException = value; }
- bool performingMicrotaskCheckpoint() const { return m_performingMicrotaskCheckpoint; }
- void setPerformingMicrotaskCheckpoint(bool performingMicrotaskCheckpoint) { m_performingMicrotaskCheckpoint = performingMicrotaskCheckpoint; }
-
-#if ENABLE(ASSERT)
- int internalScriptRecursionLevel() const { return m_internalScriptRecursionLevel; }
- int incrementInternalScriptRecursionLevel() { return ++m_internalScriptRecursionLevel; }
- int decrementInternalScriptRecursionLevel() { return --m_internalScriptRecursionLevel; }
-#endif
-
V8HiddenValue* hiddenValue() { return m_hiddenValue.get(); }
v8::Local<v8::FunctionTemplate> domTemplate(const void* domTemplateKey, v8::FunctionCallback = 0, v8::Local<v8::Value> data = v8::Local<v8::Value>(), v8::Local<v8::Signature> = v8::Local<v8::Signature>(), int length = 0);
@@ -131,7 +118,6 @@ private:
bool hasInstance(const WrapperTypeInfo* untrusted, v8::Local<v8::Value>, DOMTemplateMap&);
v8::Local<v8::Object> findInstanceInPrototypeChain(const WrapperTypeInfo*, v8::Local<v8::Value>, DOMTemplateMap&);
- bool m_destructionPending;
OwnPtr<gin::IsolateHolder> m_isolateHolder;
DOMTemplateMap m_domTemplateMapForMainWorld;
DOMTemplateMap m_domTemplateMapForNonMainWorld;
@@ -143,15 +129,9 @@ private:
bool m_constructorMode;
friend class ConstructorMode;
- int m_recursionLevel;
bool m_isHandlingRecursionLevelError;
bool m_isReportingException;
-#if ENABLE(ASSERT)
- int m_internalScriptRecursionLevel;
-#endif
- bool m_performingMicrotaskCheckpoint;
-
Vector<OwnPtr<EndOfScopeTask>> m_endOfScopeTasks;
OwnPtr<ThreadDebugger> m_threadDebugger;
};

Powered by Google App Engine
This is Rietveld 408576698