Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1719363002:
Collect information about failing histogram factory calls. (Closed)
|
Created:
4 years, 10 months ago by bcwhite Modified:
4 years, 9 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCollect information about failing histogram factory calls.
Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL.
This CL will be reverted once the necessary information has been collected, including re-enabling of any tests.
SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected.
BUG=588946
Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4
Cr-Commit-Position: refs/heads/master@{#378957}
Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86
Cr-Commit-Position: refs/heads/master@{#379323}
Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5
Cr-Commit-Position: refs/heads/master@{#379489}
Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030
Cr-Commit-Position: refs/heads/master@{#379690}
Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e
Cr-Commit-Position: refs/heads/master@{#380070}
Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d
Cr-Commit-Position: refs/heads/master@{#380474}
Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa
Cr-Commit-Position: refs/heads/master@{#380889}
Committed: https://crrev.com/30226c80730aad905d7949289c840069befb40fb
Cr-Commit-Position: refs/heads/master@{#381774}
Patch Set 1 #
Total comments: 2
Patch Set 2 : initialize extracted variables; disable test that crashes if run without DCHECK #Patch Set 3 : disabled an extension test that is creating a metric with bad construction args #Patch Set 4 : capture values of existing histogram that is failing arguments-check #Patch Set 5 : more checks to find zero'd min/max values #Patch Set 6 : extend reporting into statistics-recorder #Patch Set 7 : add checking to conversion from MD5 digest to uint64_t #Patch Set 8 : check copy of persistent hitogram_data structure #Patch Set 9 : check if MD5Sum is doing anything at all #Patch Set 10 : rebased #
Messages
Total messages: 112 (62 generated)
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
https://codereview.chromium.org/1719363002/diff/1/base/metrics/histogram.cc File base/metrics/histogram.cc (right): https://codereview.chromium.org/1719363002/diff/1/base/metrics/histogram.cc#n... base/metrics/histogram.cc:159: const BucketRanges* created_ranges; Please initialize these to nullptr or something, else these will have garbage values if the if below doesn't run.
Patchset #2 (id:20001) has been deleted
Current build failures are outside this CL. https://codereview.chromium.org/1719363002/diff/1/base/metrics/histogram.cc File base/metrics/histogram.cc (right): https://codereview.chromium.org/1719363002/diff/1/base/metrics/histogram.cc#n... base/metrics/histogram.cc:159: const BucketRanges* created_ranges; On 2016/02/26 19:12:50, Alexei Svitkine (slow) wrote: > Please initialize these to nullptr or something, else these will have garbage > values if the if below doesn't run. Done.
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/40001
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. BUG=588946 ========== to ========== Collect information about failing histogram factory calls. BUG=588946 Committed: https://crrev.com/fdc36c10667c4f6d5f4d9f391733774ae24666ce Cr-Commit-Position: refs/heads/master@{#378884} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fdc36c10667c4f6d5f4d9f391733774ae24666ce Cr-Commit-Position: refs/heads/master@{#378884}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/1758993002/ by dimich@chromium.org. The reason for reverting is: Breaks at least one test: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/17129 BUG=591580 .
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. BUG=588946 Committed: https://crrev.com/fdc36c10667c4f6d5f4d9f391733774ae24666ce Cr-Commit-Position: refs/heads/master@{#378884} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 ==========
Patchset #3 (id:60001) has been deleted
Patchset #3 (id:80001) has been deleted
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps100001 (title: "disabled an extension test that is creating a metric with bad construction args")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/100001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:100001) has been created in https://codereview.chromium.org/1768563002/ by bcwhite@chromium.org. The reason for reverting is: Information collected. May submit with additional collection operations based on results..
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} ==========
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps120001 (title: "capture values of existing histogram that is failing arguments-check")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/120001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:120001) has been created in https://codereview.chromium.org/1766963002/ by bcwhite@chromium.org. The reason for reverting is: Good results. Reverting until analysis shows what to do next..
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} ==========
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps160001 (title: "more checks to find zero'd min/max values")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/160001
Patchset #5 (id:140001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/160001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} ==========
Message was sent while issue was closed.
Committed patchset #5 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:160001) has been created in https://codereview.chromium.org/1771843002/ by bcwhite@chromium.org. The reason for reverting is: Problem isolated to bad StatisticsRecorder lookup. Expect another landing with even more data collection..
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} ==========
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps180001 (title: "extend reporting into statistics-recorder")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/180001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:180001) has been created in https://codereview.chromium.org/1774973003/ by bcwhite@chromium.org. The reason for reverting is: Build is no longer exhibiting crashes as before. It's as though the debug code is preventing whatever error is causing the crashes, or at least those caused by the StatisticsRecorder finding the wrong Histogram. More to follow....
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} ==========
Patchset #7 (id:200001) has been deleted
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps220001 (title: "add checking to conversion from MD5 digest to uint64_t")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/220001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} ==========
Message was sent while issue was closed.
Committed patchset #7 (id:220001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:220001) has been created in https://codereview.chromium.org/1776973002/ by bcwhite@chromium.org. The reason for reverting is: Successful build 51.0.2672. Reverting while waiting for crash reports..
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} ==========
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps240001 (title: "check copy of persistent hitogram_data structure")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/240001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} ==========
Message was sent while issue was closed.
Committed patchset #8 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474}
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:240001) has been created in https://codereview.chromium.org/1777223004/ by bcwhite@chromium.org. The reason for reverting is: Confirmed in 51.0.2674. Reverting while crashes are analyzed..
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} ==========
Patchset #9 (id:260001) has been deleted
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps280001 (title: "check if MD5Sum is doing anything at all")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/280001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} ==========
Message was sent while issue was closed.
Committed patchset #9 (id:280001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889}
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:280001) has been created in https://codereview.chromium.org/1797963004/ by bcwhite@chromium.org. The reason for reverting is: In build 51.0.2677... but not doing anything. The crash is not occurring..
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} ==========
Patchset #10 (id:300001) has been deleted
Patchset #10 (id:320001) has been deleted
Patchset #10 (id:340001) has been deleted
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1719363002/#ps360001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719363002/360001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719363002/360001
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} ==========
Message was sent while issue was closed.
Committed patchset #10 (id:360001)
Message was sent while issue was closed.
Description was changed from ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} ========== to ========== Collect information about failing histogram factory calls. Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} Committed: https://crrev.com/30226c80730aad905d7949289c840069befb40fb Cr-Commit-Position: refs/heads/master@{#381774} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/30226c80730aad905d7949289c840069befb40fb Cr-Commit-Position: refs/heads/master@{#381774}
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:360001) has been created in https://codereview.chromium.org/1825143002/ by bcwhite@chromium.org. The reason for reverting is: Information collected.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
