Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1766963002: Revert of Collect information about failing histogram factory calls. (Closed)

Created:
4 years, 9 months ago by bcwhite
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Collect information about failing histogram factory calls. (patchset #4 id:120001 of https://codereview.chromium.org/1719363002/ ) Reason for revert: Good results. Reverting until analysis shows what to do next. Original issue's description: > Collect information about failing histogram factory calls. > > Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. > > This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. > > SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. > > BUG=588946 > > Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 > Cr-Commit-Position: refs/heads/master@{#378957} > > Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 > Cr-Commit-Position: refs/heads/master@{#379323} TBR=asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=588946 Committed: https://crrev.com/d283075166d7f46c73e9f4babb69c49699810b2a Cr-Commit-Position: refs/heads/master@{#379479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -61 lines) Patch
M base/metrics/histogram.cc View 4 chunks +7 lines, -59 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
bcwhite
Created Revert of Collect information about failing histogram factory calls.
4 years, 9 months ago (2016-03-05 21:18:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766963002/1
4 years, 9 months ago (2016-03-05 21:18:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766963002/1
4 years, 9 months ago (2016-03-05 21:31:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766963002/1
4 years, 9 months ago (2016-03-05 22:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766963002/1
4 years, 9 months ago (2016-03-05 22:31:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 22:37:49 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 22:39:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d283075166d7f46c73e9f4babb69c49699810b2a
Cr-Commit-Position: refs/heads/master@{#379479}

Powered by Google App Engine
This is Rietveld 408576698