Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1758993002: Revert of Collect information about failing histogram factory calls. (Closed)

Created:
4 years, 9 months ago by Dmitry Titov
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Collect information about failing histogram factory calls. (patchset #2 id:40001 of https://codereview.chromium.org/1719363002/ ) Reason for revert: Breaks at least one test: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/17129 BUG=591580 Original issue's description: > Collect information about failing histogram factory calls. > > BUG=588946 > > Committed: https://crrev.com/fdc36c10667c4f6d5f4d9f391733774ae24666ce > Cr-Commit-Position: refs/heads/master@{#378884} TBR=asvitkine@chromium.org,bcwhite@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588946 Committed: https://crrev.com/cfbec0cfb2d25d36b67bd297ebea4a622a4faa74 Cr-Commit-Position: refs/heads/master@{#378903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -48 lines) Patch
M base/metrics/histogram.cc View 3 chunks +7 lines, -47 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Titov
Created Revert of Collect information about failing histogram factory calls.
4 years, 9 months ago (2016-03-03 01:14:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758993002/1
4 years, 9 months ago (2016-03-03 01:14:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 01:15:33 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:16:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfbec0cfb2d25d36b67bd297ebea4a622a4faa74
Cr-Commit-Position: refs/heads/master@{#378903}

Powered by Google App Engine
This is Rietveld 408576698