Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 1771843002: Revert of Collect information about failing histogram factory calls. (Closed)

Created:
4 years, 9 months ago by bcwhite
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Collect information about failing histogram factory calls. (patchset #5 id:160001 of https://codereview.chromium.org/1719363002/ ) Reason for revert: Problem isolated to bad StatisticsRecorder lookup. Expect another landing with even more data collection. Original issue's description: > Collect information about failing histogram factory calls. > > Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. > > This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. > > SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. > > BUG=588946 > > Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 > Cr-Commit-Position: refs/heads/master@{#378957} > > Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 > Cr-Commit-Position: refs/heads/master@{#379323} > > Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 > Cr-Commit-Position: refs/heads/master@{#379489} TBR=asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588946 Committed: https://crrev.com/2253d92721e12ae7a7af8fd0368cb02ed4d0f439 Cr-Commit-Position: refs/heads/master@{#379560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -91 lines) Patch
M base/metrics/histogram.cc View 8 chunks +7 lines, -87 lines 0 comments Download
M base/metrics/histogram_persistence.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
bcwhite
Created Revert of Collect information about failing histogram factory calls.
4 years, 9 months ago (2016-03-07 16:31:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771843002/1
4 years, 9 months ago (2016-03-07 16:32:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 16:32:48 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 16:34:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2253d92721e12ae7a7af8fd0368cb02ed4d0f439
Cr-Commit-Position: refs/heads/master@{#379560}

Powered by Google App Engine
This is Rietveld 408576698