Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1797963004: Revert of Collect information about failing histogram factory calls. (Closed)

Created:
4 years, 9 months ago by bcwhite
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Collect information about failing histogram factory calls. (patchset #9 id:280001 of https://codereview.chromium.org/1719363002/ ) Reason for revert: In build 51.0.2677... but not doing anything. The crash is not occurring. Original issue's description: > Collect information about failing histogram factory calls. > > Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. > > This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. > > SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. > > BUG=588946 > > Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 > Cr-Commit-Position: refs/heads/master@{#378957} > > Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 > Cr-Commit-Position: refs/heads/master@{#379323} > > Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 > Cr-Commit-Position: refs/heads/master@{#379489} > > Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 > Cr-Commit-Position: refs/heads/master@{#379690} > > Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e > Cr-Commit-Position: refs/heads/master@{#380070} > > Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d > Cr-Commit-Position: refs/heads/master@{#380474} > > Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa > Cr-Commit-Position: refs/heads/master@{#380889} TBR=asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=588946 Committed: https://crrev.com/f65e5d3d046f168889338ffba2cba5df140e9fb7 Cr-Commit-Position: refs/heads/master@{#381027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -148 lines) Patch
M base/metrics/histogram.cc View 8 chunks +7 lines, -87 lines 0 comments Download
M base/metrics/histogram_persistence.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/metrics_hashes.cc View 2 chunks +3 lines, -30 lines 0 comments Download
M base/metrics/statistics_recorder.cc View 3 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (1 generated)
bcwhite
Created Revert of Collect information about failing histogram factory calls.
4 years, 9 months ago (2016-03-14 15:29:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 15:30:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 15:31:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 16:01:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 16:31:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 17:01:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 17:31:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 18:01:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1797963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1797963004/1
4 years, 9 months ago (2016-03-14 18:31:40 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 9 months ago (2016-03-14 18:34:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 18:52:12 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 18:53:21 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f65e5d3d046f168889338ffba2cba5df140e9fb7
Cr-Commit-Position: refs/heads/master@{#381027}

Powered by Google App Engine
This is Rietveld 408576698