base/metrics/histogram_unittest.cc - Issue 1719363002: Collect information about failing histogram factory calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_unittest.cc

Issue 1719363002: Collect information about failing histogram factory calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_unittest.cc

diff --git a/base/metrics/histogram_unittest.cc b/base/metrics/histogram_unittest.cc

index 03dc7bda8b912f9ab30ca03e54459303e8829c02..15109b1a5b60fe29ce3a451d904b9855d5b52edf 100644

--- a/base/metrics/histogram_unittest.cc

+++ b/base/metrics/histogram_unittest.cc

@@ -574,7 +574,7 @@ TEST_P(HistogramTest, CustomHistogramSerializeInfo) {

EXPECT_FALSE(iter.SkipBytes(1));

}

-TEST_P(HistogramTest, BadConstruction) {

+TEST_P(HistogramTest, DISABLED_BadConstruction) {

HistogramBase* histogram = Histogram::FactoryGet(

"BadConstruction", 0, 100, 8, HistogramBase::kNoFlags);

EXPECT_TRUE(histogram->HasConstructionArguments(1, 100, 8));

« no previous file with comments | « base/metrics/histogram.cc ('k') | base/metrics/metrics_hashes.cc » ('j') | no next file with comments »