Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1774973003: Revert of Collect information about failing histogram factory calls. (Closed)

Created:
4 years, 9 months ago by bcwhite
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Collect information about failing histogram factory calls. (patchset #6 id:180001 of https://codereview.chromium.org/1719363002/ ) Reason for revert: Build is no longer exhibiting crashes as before. It's as though the debug code is preventing whatever error is causing the crashes, or at least those caused by the StatisticsRecorder finding the wrong Histogram. More to follow... Original issue's description: > Collect information about failing histogram factory calls. > > Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. > > This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. > > SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. > > BUG=588946 > > Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 > Cr-Commit-Position: refs/heads/master@{#378957} > > Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 > Cr-Commit-Position: refs/heads/master@{#379323} > > Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 > Cr-Commit-Position: refs/heads/master@{#379489} > > Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 > Cr-Commit-Position: refs/heads/master@{#379690} TBR=asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588946 Committed: https://crrev.com/9a970497f8156147c3f6467d325003e79f5d6de8 Cr-Commit-Position: refs/heads/master@{#379865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -112 lines) Patch
M base/metrics/histogram.cc View 8 chunks +7 lines, -87 lines 0 comments Download
M base/metrics/histogram_persistence.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/statistics_recorder.cc View 3 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
bcwhite
Created Revert of Collect information about failing histogram factory calls.
4 years, 9 months ago (2016-03-08 18:20:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774973003/1
4 years, 9 months ago (2016-03-08 18:20:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 18:21:11 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 18:22:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a970497f8156147c3f6467d325003e79f5d6de8
Cr-Commit-Position: refs/heads/master@{#379865}

Powered by Google App Engine
This is Rietveld 408576698