Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1718693002: Add vulkan files into skia repo. (Closed)

Created:
4 years, 10 months ago by egdaniel
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@merge
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : blacklist vk directory in test_public_includes #

Patch Set 4 : fix path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13570 lines, -52 lines) Patch
A gyp/gpuVk.gyp View 1 chunk +202 lines, -0 lines 0 comments Download
A gyp/gpuVk.gypi View 1 chunk +81 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A include/gpu/vk/GrVkInterface.h View 1 chunk +218 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkBuffer.h View 1 chunk +92 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkBuffer.cpp View 1 chunk +177 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkCaps.h View 1 chunk +108 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkCaps.cpp View 1 chunk +244 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkCommandBuffer.h View 1 chunk +206 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkCommandBuffer.cpp View 1 chunk +371 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkDescriptorPool.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkDescriptorPool.cpp View 1 chunk +79 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkFramebuffer.h View 1 chunk +45 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkFramebuffer.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkGpu.h View 1 chunk +220 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkGpu.cpp View 1 chunk +1272 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkImage.h View 1 chunk +108 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkImage.cpp View 1 chunk +118 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkImageView.h View 1 chunk +41 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkImageView.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkIndexBuffer.h View 1 chunk +39 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkIndexBuffer.cpp View 1 chunk +76 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkInterface.cpp View 1 chunk +340 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkMemory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkMemory.cpp View 1 chunk +157 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkPipeline.h View 1 chunk +49 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkPipeline.cpp View 1 chunk +507 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgram.h View 1 chunk +161 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgram.cpp View 1 chunk +367 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgramBuilder.h View 1 chunk +74 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgramBuilder.cpp View 1 chunk +323 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgramDataManager.h View 1 chunk +70 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgramDataManager.cpp View 1 chunk +315 lines, -0 lines 0 comments Download
A + src/gpu/vk/GrVkProgramDesc.h View 3 chunks +15 lines, -10 lines 0 comments Download
A + src/gpu/vk/GrVkProgramDesc.cpp View 8 chunks +29 lines, -42 lines 0 comments Download
A src/gpu/vk/GrVkRenderPass.h View 1 chunk +90 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkRenderPass.cpp View 1 chunk +220 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkRenderTarget.h View 1 chunk +137 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkRenderTarget.cpp View 1 chunk +391 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkResource.h View 1 chunk +170 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkResourceProvider.h View 1 chunk +77 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkResourceProvider.cpp View 1 chunk +118 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkSampler.h View 1 chunk +35 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkSampler.cpp View 1 chunk +74 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkStencilAttachment.h View 1 chunk +62 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkStencilAttachment.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkTexture.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkTexture.cpp View 1 chunk +124 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkTextureRenderTarget.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkTextureRenderTarget.cpp View 1 chunk +150 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkTransferBuffer.h View 1 chunk +54 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkTransferBuffer.cpp View 1 chunk +58 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkUniformBuffer.h View 1 chunk +45 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkUniformBuffer.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkUniformHandler.h View 1 chunk +85 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkUniformHandler.cpp View 1 chunk +149 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkUtil.h View 1 chunk +36 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkUtil.cpp View 1 chunk +94 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkVaryingHandler.h View 1 chunk +27 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkVaryingHandler.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkVertexBuffer.h View 1 chunk +38 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkVertexBuffer.cpp View 1 chunk +75 lines, -0 lines 0 comments Download
A tests/VkClearTests.cpp View 1 chunk +218 lines, -0 lines 0 comments Download
A tests/VkUploadPixelsTests.cpp View 1 chunk +160 lines, -0 lines 0 comments Download
A third_party/shaderc/Debug/OGLCompiler.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/OSDependent.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/SPIRV.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/SPIRV-Tools.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/glslang.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/shaderc.lib View Binary file 0 comments Download
A third_party/shaderc/Debug/shaderc_util.lib View Binary file 0 comments Download
A third_party/shaderc/Release/OGLCompiler.lib View Binary file 0 comments Download
A third_party/shaderc/Release/OSDependent.lib View Binary file 0 comments Download
A third_party/shaderc/Release/SPIRV.lib View Binary file 0 comments Download
A third_party/shaderc/Release/SPIRV-Tools.lib View Binary file 0 comments Download
A third_party/shaderc/Release/glslang.lib View Binary file 0 comments Download
A third_party/shaderc/Release/shaderc.lib View Binary file 0 comments Download
A third_party/shaderc/Release/shaderc_util.lib View Binary file 0 comments Download
A third_party/shaderc/shaderc.h View 1 chunk +327 lines, -0 lines 0 comments Download
A third_party/vulkan/vk_platform.h View 1 chunk +127 lines, -0 lines 0 comments Download
A third_party/vulkan/vulkan.h View 1 chunk +3775 lines, -0 lines 0 comments Download
A third_party/vulkan/vulkan-1.lib View Binary file 0 comments Download
A tools/generate_vk_interface.sh View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
egdaniel
Still waiting on Brian's pre merge cl to land, but then this should be good ...
4 years, 10 months ago (2016-02-19 22:15:05 UTC) #3
robertphillips
rs lgtm
4 years, 10 months ago (2016-02-19 22:16:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718693002/20001
4 years, 10 months ago (2016-02-19 22:32:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/475)
4 years, 10 months ago (2016-02-19 22:34:08 UTC) #11
egdaniel
Committed patchset #2 (id:20001) manually as 48cf268defad66f58f1aa03b4835e5583be96b2f (presubmit successful).
4 years, 10 months ago (2016-02-22 14:12:07 UTC) #14
egdaniel
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1723503002/ by egdaniel@google.com. ...
4 years, 10 months ago (2016-02-22 14:17:19 UTC) #15
egdaniel
4 years, 10 months ago (2016-02-22 14:56:47 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
164a9f061c5186ae931cc23a3c73f32472e80ff5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698