Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1693113002: Revert of Add infastructure for gl_SampleMask (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload7_interp
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add infastructure for gl_SampleMask (patchset #6 id:100001 of https://codereview.chromium.org/1690963003/ ) Reason for revert: Several bots failing with error 'invalid profile "es" for version 320'. Original issue's description: > Add infastructure for gl_SampleMask > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690963003 > > Committed: https://skia.googlesource.com/skia/+/533cefe5b9c7cec2592fc7ca00ee4cf69a26c094 TBR=egdaniel@google.com,bsalomon@google.com,cdalton@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1751dc74f95a409fdb8cdc5c4efae20b1c39509a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -103 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/glsl/GrGLSL.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/glsl/GrGLSL.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 4 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +7 lines, -28 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dogben
Created Revert of Add infastructure for gl_SampleMask
4 years, 10 months ago (2016-02-12 23:20:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693113002/1
4 years, 10 months ago (2016-02-12 23:20:45 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 23:20:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1751dc74f95a409fdb8cdc5c4efae20b1c39509a

Powered by Google App Engine
This is Rietveld 408576698