Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1668003003: Call CXFA_Object::ToNode() rather than C-style casting. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Call CXFA_Object::ToNode() rather than C-style casting. The static_casts<> are places where void* pointers are converted. Fix these in a subsequent CL by using a properly typed container. The const_casts<> are places where functions are missing "consts". Fix these in a subsequent CL, too. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/99f20ebb09f515a6e3798b948fe66760383c9304

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -231 lines) Patch
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 4 chunks +4 lines, -9 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdochandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 12 chunks +19 lines, -17 lines 1 comment Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp View 12 chunks +41 lines, -43 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp View 10 chunks +20 lines, -25 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_imp.cpp View 6 chunks +7 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_layout_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_serialize.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 27 chunks +53 lines, -52 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_objectacc_imp.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_imp.cpp View 12 chunks +20 lines, -21 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp View 13 chunks +22 lines, -23 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_signaturepseudomodel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
4 years, 10 months ago (2016-02-04 01:16:24 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1668003003/diff/1/xfa/src/fxfa/src/app/xfa_ffdocview.cpp File xfa/src/fxfa/src/app/xfa_ffdocview.cpp (right): https://codereview.chromium.org/1668003003/diff/1/xfa/src/fxfa/src/app/xfa_ffdocview.cpp#newcode173 xfa/src/fxfa/src/app/xfa_ffdocview.cpp:173: CXFA_Node* pNode = reinterpret_cast<CXFA_Node*>(m_NewAddedNodes[i]); Gah, a CFX_PtrArray!
4 years, 10 months ago (2016-02-04 01:41:04 UTC) #2
Tom Sepez
4 years, 10 months ago (2016-02-04 17:32:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
99f20ebb09f515a6e3798b948fe66760383c9304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698