Call CXFA_Object::ToNode() rather than C-style casting.

xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/src/foxitlib.h"
 #include "xfa/src/fxfa/src/common/xfa_utils.h"
 #include "xfa/src/fxfa/src/common/xfa_object.h"
 #include "xfa/src/fxfa/src/common/xfa_document.h"
@@ skipping 74 matching lines @@
     CXFA_ResolveNodesData& rnd) {
   CFX_WideString wsName = rnd.m_wsName.Right(rnd.m_wsName.GetLength() - 1);
   CFX_WideString wsCondition = rnd.m_wsCondition;
   CXFA_Node* findNode = NULL;
   CXFA_NodeArray siblings;
   FX_BOOL bClassName = FALSE;
   if (wsName.GetAt(0) == '#') {
     bClassName = TRUE;
     wsName = wsName.Right(wsName.GetLength() - 1);
   }
-  findNode = m_pNodeHelper->XFA_ResolveNodes_GetOneChild(
-      (CXFA_Node*)rnd.m_CurNode, wsName, bClassName);
+  findNode = m_pNodeHelper->XFA_ResolveNodes_GetOneChild(ToNode(rnd.m_CurNode),
+                                                         wsName, bClassName);
   if (findNode == NULL) {
     return 0;
   }
   if (wsCondition.IsEmpty()) {
     rnd.m_Nodes.Add(findNode);
     return rnd.m_Nodes.GetSize();
   }
   m_pNodeHelper->XFA_CountSiblings(findNode, XFA_LOGIC_Transparent,
                                    (CXFA_NodeArray*)&rnd.m_Nodes, bClassName);
   XFA_ResolveNode_FilterCondition(rnd, wsCondition);
@@ skipping 26 matching lines @@
     XFA_ResolveNode_FilterCondition(rnd, wsCondition);
   }
   return rnd.m_Nodes.GetSize();
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_Excalmatory(
     CXFA_ResolveNodesData& rnd) {
   if (rnd.m_nLevel > 0) {
     return 0;
   }
   CXFA_Node* datasets =
-      (CXFA_Node*)rnd.m_pSC->GetDocument()->GetXFAObject(XFA_HASHCODE_Datasets);
-  if (datasets == NULL) {
+      ToNode(rnd.m_pSC->GetDocument()->GetXFAObject(XFA_HASHCODE_Datasets));
+  if (!datasets) {
     return 0;
   }
   CXFA_ResolveNodesData rndFind;
   rndFind.m_pSC = rnd.m_pSC;
   rndFind.m_CurNode = datasets;
   rndFind.m_wsName = rnd.m_wsName.Right(rnd.m_wsName.GetLength() - 1);
   rndFind.m_uHashName =
       FX_HashCode_String_GetW(rndFind.m_wsName, rndFind.m_wsName.GetLength());
   rndFind.m_nLevel = rnd.m_nLevel + 1;
   rndFind.m_dwStyles = XFA_RESOLVENODE_Children;
   rndFind.m_wsCondition = rnd.m_wsCondition;
   XFA_ResolveNodes(rndFind);
   if (rndFind.m_Nodes.GetSize() > 0) {
     rnd.m_Nodes.Append(rndFind.m_Nodes);
     rndFind.m_Nodes.RemoveAll();
   }
   return rnd.m_Nodes.GetSize();
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_NumberSign(
     CXFA_ResolveNodesData& rnd) {
   CFX_WideString wsName = rnd.m_wsName.Right(rnd.m_wsName.GetLength() - 1);
   CFX_WideString wsCondition = rnd.m_wsCondition;
-  CXFA_Node* curNode = (CXFA_Node*)rnd.m_CurNode;
+  CXFA_Node* curNode = ToNode(rnd.m_CurNode);
   if (XFA_ResolveNodes_ForAttributeRs(curNode, rnd, wsName)) {
     return 1;
   }
   CXFA_ResolveNodesData rndFind;
   rndFind.m_pSC = rnd.m_pSC;
   rndFind.m_nLevel = rnd.m_nLevel + 1;
   rndFind.m_dwStyles = rnd.m_dwStyles;
   rndFind.m_dwStyles |= XFA_RESOLVENODE_TagName;
   rndFind.m_dwStyles &= ~XFA_RESOLVENODE_Attributes;
   rndFind.m_wsName = wsName;
@@ skipping 27 matching lines @@
   return 0;
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_Normal(
     CXFA_ResolveNodesData& rnd) {
   if (rnd.m_nLevel > 32) {
     return 0;
   }
   if (!rnd.m_CurNode->IsNode()) {
     return 0;
   }
-  CXFA_Node* curNode = (CXFA_Node*)rnd.m_CurNode;
+  CXFA_Node* curNode = ToNode(rnd.m_CurNode);
   CXFA_ObjArray& nodes = rnd.m_Nodes;
   int32_t nNum = nodes.GetSize();
   FX_DWORD dwStyles = rnd.m_dwStyles;
   CFX_WideString& wsName = rnd.m_wsName;
   uint32_t uNameHash = rnd.m_uHashName;
   CFX_WideString& wsCondition = rnd.m_wsCondition;
   CXFA_ResolveNodesData rndFind;
   rndFind.m_wsName = rnd.m_wsName;
   rndFind.m_wsCondition = rnd.m_wsCondition;
   rndFind.m_pSC = rnd.m_pSC;
@@ skipping 75 matching lines @@
         rndFind.m_wsCondition = wsSaveCondition;
         if (rndFind.m_Nodes.GetSize() > 0) {
           nodes.Append(rndFind.m_Nodes);
           rndFind.m_Nodes.RemoveAll();
         }
       }
     }
     if (nodes.GetSize() > nNum) {
       if (!(dwStyles & XFA_RESOLVENODE_ALL)) {
         CXFA_NodeArray upArrayNodes;
-        if (m_pNodeHelper->XFA_NodeIsTransparent((CXFA_Node*)curNode)) {
+        if (m_pNodeHelper->XFA_NodeIsTransparent(ToNode(curNode))) {
           m_pNodeHelper->XFA_CountSiblings(
-              (CXFA_Node*)nodes[0], XFA_LOGIC_Transparent, &upArrayNodes,
+              ToNode(nodes[0]), XFA_LOGIC_Transparent, &upArrayNodes,
               !!(dwStyles & XFA_RESOLVENODE_TagName));
         }
         if (upArrayNodes.GetSize() > nodes.GetSize()) {
-          upArrayNodes[0] = (CXFA_Node*)nodes[0];
+          upArrayNodes[0] = ToNode(nodes[0]);
           nodes.RemoveAll();
           nodes.Append((CXFA_ObjArray&)upArrayNodes);
           upArrayNodes.RemoveAll();
         }
       }
       XFA_ResolveNode_FilterCondition(rnd, wsCondition);
       if (nodes.GetSize() > 0) {
         return 1;
       }
       return 0;
@@ skipping 22 matching lines @@
       XFA_ResolveNode_FilterCondition(rnd, wsCondition);
       if (nodes.GetSize() > 0) {
         return 1;
       }
       return 0;
     }
     CXFA_Node* pProp = NULL;
     if (XFA_ELEMENT_Subform == curNode->GetClassID() &&
         XFA_HASHCODE_Occur == uNameHash) {
       CXFA_Node* pInstanceManager =
-          ((CXFA_Node*)curNode)->GetInstanceMgrOfSubform();
+          curNode->AsNode()->GetInstanceMgrOfSubform();
       if (pInstanceManager) {
         pProp = pInstanceManager->GetProperty(0, XFA_ELEMENT_Occur, TRUE);
       }
     } else {
       XFA_LPCELEMENTINFO pElement = XFA_GetElementByName(wsName);
       if (pElement) {
-        pProp = ((CXFA_Node*)curNode)
-                    ->GetProperty(0, pElement->eName,
-                                  pElement->eName != XFA_ELEMENT_PageSet);
+        pProp = curNode->AsNode()->GetProperty(
+            0, pElement->eName, pElement->eName != XFA_ELEMENT_PageSet);
       }
     }
     if (pProp) {
       nodes.Add(pProp);
       return nodes.GetSize();
     }
   }
   CXFA_Node* parentNode = m_pNodeHelper->XFA_ResolveNodes_GetParent(
-      (CXFA_Node*)curNode, XFA_LOGIC_NoTransparent);
+      curNode->AsNode(), XFA_LOGIC_NoTransparent);
   uint32_t uCurClassHash = curNode->GetClassHashCode();
-  if (parentNode == NULL) {
+  if (!parentNode) {
     if (uCurClassHash == uNameHash) {
-      nodes.Add((CXFA_Node*)curNode);
+      nodes.Add(curNode->AsNode());
       XFA_ResolveNode_FilterCondition(rnd, wsCondition);
       if (nodes.GetSize() > 0) {
         return 1;
       }
     }
     return 0;
   }
   if (dwStyles & XFA_RESOLVENODE_Siblings) {
     CXFA_Node* child = parentNode->GetNodeItem(XFA_NODEITEM_FirstChild);
     FX_DWORD dwSubStyles =
@@ skipping 57 matching lines @@
           nodes.Append(rndFind.m_Nodes);
           rndFind.m_Nodes.RemoveAll();
         }
       }
       child = child->GetNodeItem(XFA_NODEITEM_NextSibling);
     }
     if (nodes.GetSize() > nNum) {
       if (m_pNodeHelper->XFA_NodeIsTransparent(parentNode)) {
         CXFA_NodeArray upArrayNodes;
         m_pNodeHelper->XFA_CountSiblings(
-            (CXFA_Node*)nodes[0], XFA_LOGIC_Transparent, &upArrayNodes,
+            ToNode(nodes[0]), XFA_LOGIC_Transparent, &upArrayNodes,
             !!(dwStyles & XFA_RESOLVENODE_TagName));
         if (upArrayNodes.GetSize() > nodes.GetSize()) {
-          upArrayNodes[0] = (CXFA_Node*)nodes[0];
+          upArrayNodes[0] = ToNode(nodes[0]);
           nodes.RemoveAll();
           nodes.Append((CXFA_ObjArray&)upArrayNodes);
           upArrayNodes.RemoveAll();
         }
       }
       XFA_ResolveNode_FilterCondition(rnd, wsCondition);
       if (nodes.GetSize() > 0) {
         return 1;
       }
       return 0;
@@ skipping 18 matching lines @@
       rndFind.m_Nodes.RemoveAll();
     }
     if (nodes.GetSize() > nNum) {
       return 1;
     }
   }
   return 0;
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_Asterisk(
     CXFA_ResolveNodesData& rnd) {
-  CXFA_Node* curNode = (CXFA_Node*)rnd.m_CurNode;
+  CXFA_Node* curNode = ToNode(rnd.m_CurNode);
   CXFA_ObjArray& nodes = rnd.m_Nodes;
   CXFA_NodeArray array;
   curNode->GetNodeList(array,
                        XFA_NODEFILTER_Children | XFA_NODEFILTER_Properties);
   nodes.Append((CXFA_ObjArray&)array);
   return nodes.GetSize();
 }
 int32_t CXFA_ResolveProcessor::XFA_ResolveNodes_PopStack(
     CFX_Int32Array& stack) {
   int32_t nType = -1;
@@ skipping 125 matching lines @@
     } else if (ch == '*') {
       bAll = TRUE;
       break;
     } else {
       break;
     }
   }
   if (bAll) {
     if (rnd.m_dwStyles & XFA_RESOLVENODE_CreateNode) {
       if (rnd.m_dwStyles & XFA_RESOLVENODE_Bind) {
-        m_pNodeHelper->m_pCreateParent = (CXFA_Node*)rnd.m_CurNode;
+        m_pNodeHelper->m_pCreateParent = ToNode(rnd.m_CurNode);
         m_pNodeHelper->m_iCreateCount = 1;
         findNodes.RemoveAll();
         m_pNodeHelper->m_iCurAllStart = -1;
         m_pNodeHelper->m_pAllStartParent = NULL;
       } else {
         if (m_pNodeHelper->m_iCurAllStart == -1) {
           m_pNodeHelper->m_iCurAllStart = m_iCurStart;
-          m_pNodeHelper->m_pAllStartParent = (CXFA_Node*)rnd.m_CurNode;
+          m_pNodeHelper->m_pAllStartParent = ToNode(rnd.m_CurNode);
         }
       }
     } else if (rnd.m_dwStyles & XFA_RESOLVENODE_BindNew) {
       if (m_pNodeHelper->m_iCurAllStart == -1) {
         m_pNodeHelper->m_iCurAllStart = m_iCurStart;
       }
     }
     return;
   }
   if (iFoundCount == 1 && !iLen) {
     return;
   }
   CFX_WideString wsIndex;
   wsIndex = wsCondition.Mid(i, iLen - 1 - i);
   int32_t iIndex = wsIndex.GetInteger();
   if (bRelative) {
     iIndex += iCurIndex;
   }
   if (iFoundCount <= iIndex || iIndex < 0) {
     if (rnd.m_dwStyles & XFA_RESOLVENODE_CreateNode) {
-      m_pNodeHelper->m_pCreateParent = (CXFA_Node*)rnd.m_CurNode;
+      m_pNodeHelper->m_pCreateParent = ToNode(rnd.m_CurNode);
       m_pNodeHelper->m_iCreateCount = iIndex - iFoundCount + 1;
     }
     findNodes.RemoveAll();
   } else {
     CXFA_Node* ret = findNodes[iIndex];
     findNodes.RemoveAll();
     findNodes.Add(ret);
   }
 }
 void CXFA_ResolveProcessor::XFA_ResolveNode_DoPredicateFilter(
@@ skipping 54 matching lines @@
   int32_t iLen = wsCondition.GetLength();
   if (!iLen) {
     if (rnd.m_dwStyles & XFA_RESOLVENODE_ALL) {
       return;
     }
     if (iFoundCount == 1) {
       return;
     }
     if (iFoundCount <= iCurrIndex) {
       if (rnd.m_dwStyles & XFA_RESOLVENODE_CreateNode) {
-        m_pNodeHelper->m_pCreateParent = (CXFA_Node*)rnd.m_CurNode;
+        m_pNodeHelper->m_pCreateParent = ToNode(rnd.m_CurNode);
         m_pNodeHelper->m_iCreateCount = iCurrIndex - iFoundCount + 1;
       }
       findNodes.RemoveAll();
       return;
     } else {
       CXFA_Node* ret = findNodes[iCurrIndex];
       findNodes.RemoveAll();
       findNodes.Add(ret);
       return;
     }
@@ skipping 52 matching lines @@
   if (m_pNodeHelper->XFA_CreateNode_ForCondition(wsNextCondition)) {
     if (m_pNodeHelper->m_eLastCreateType == XFA_ELEMENT_DataGroup) {
       iIndex = 0;
     } else {
       iIndex = iCount - 1;
     }
   } else {
     iIndex = iCount - 1;
   }
 }