xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp - Issue 1668003003: Call CXFA_Object::ToNode() rather than C-style casting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

Issue 1668003003: Call CXFA_Object::ToNode() rather than C-style casting. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

diff --git a/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp b/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

index cbfdb09fc4d31205cd79dd344e7e2e770e8b1f57..f3b1276797d2debcab7103f8171d111231f87c7a 100644

--- a/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

+++ b/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

@@ -1770,7 +1770,7 @@ static FX_FLOAT XFA_ItemLayoutProcessor_InsertPendingItems(

while (pProcessor->m_rgPendingNodes.GetCount() > 0) {

FX_POSITION pos = pProcessor->m_rgPendingNodes.GetHeadPosition();

CXFA_Node* pPendingNode =

- (CXFA_Node*)pProcessor->m_rgPendingNodes.GetAt(pos);

+ reinterpret_cast<CXFA_Node*>(pProcessor->m_rgPendingNodes.GetAt(pos));

pProcessor->m_rgPendingNodes.RemoveAt(pos);

CXFA_ContentLayoutItem* pPendingLayoutItem = NULL;

CXFA_ItemLayoutProcessor* pPendingProcessor =