Call CXFA_Object::ToNode() rather than C-style casting.

xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa_fm2js.h"
 #include <time.h>
 #define FINANCIAL_PRECISION 0.00000001
 struct XFA_FMHtmlReserveCode {
@@ skipping 1531 matching lines @@
         HValueToUTF8String(localValue, localString);
       }
     }
     if (!bFlags) {
       CXFA_FM2JSContext* pContext =
           (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
       CXFA_Document* pDoc = pContext->GetDocument();
       IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
       IFX_Locale* pLocale = NULL;
       if (localString.IsEmpty()) {
-        CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-        FXSYS_assert(pThisNode->IsNode());
-        CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+        CXFA_Node* pThisNode =
+            ToNode(pDoc->GetScriptContext()->GetThisObject());
+        FXSYS_assert(pThisNode);
+        CXFA_WidgetData widgetData(pThisNode);
         pLocale = widgetData.GetLocal();
       } else {
         pLocale = pMgr->GetLocaleByName(
             CFX_WideString::FromUTF8(localString, localString.GetLength()));
       }
       CFX_WideString wsFormat;
       if (formatString.IsEmpty()) {
         pLocale->GetTimePattern(FX_LOCALEDATETIMESUBCATEGORY_Default, wsFormat);
       } else {
         wsFormat =
@@ skipping 426 matching lines @@
                                          CFX_ByteString& strIsoDate) {
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return FALSE;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
@@ skipping 17 matching lines @@
                                          CFX_ByteString& strIsoTime) {
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return FALSE;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
@@ skipping 20 matching lines @@
                                          CFX_ByteString& strLocalDate) {
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return FALSE;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
@@ skipping 19 matching lines @@
                                          CFX_ByteString& strLocalTime) {
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return FALSE;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
@@ skipping 21 matching lines @@
                                       CFX_ByteString& strGMTTime) {
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return FALSE;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocale.IsEmpty()) {
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocale.GetCStr(), szLocale.GetLength()));
   }
   if (!pLocale) {
     return FALSE;
   }
   CFX_WideString wsFormat;
   if (szFormat.IsEmpty()) {
@@ skipping 162 matching lines @@
   }
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocalStr.IsEmpty()) {
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocalStr.GetCStr(), szLocalStr.GetLength()));
   }
   if (!pLocale) {
     return;
   }
   CFX_WideString strRet;
   pLocale->GetDatePattern(strStyle, strRet);
@@ skipping 32 matching lines @@
   }
   CXFA_FM2JSContext* pContext =
       (CXFA_FM2JSContext*)FXJSE_Value_ToObject(hThis, NULL);
   CXFA_Document* pDoc = pContext->GetDocument();
   if (!pDoc) {
     return;
   }
   IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
   IFX_Locale* pLocale = NULL;
   if (szLocalStr.IsEmpty()) {
-    CXFA_Object* pThisObject = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisObject->IsNode());
-    CXFA_Node* pThisNode = (CXFA_Node*)pThisObject;
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
     CXFA_WidgetData widgetData(pThisNode);
     pLocale = widgetData.GetLocal();
   } else {
     pLocale = pMgr->GetLocaleByName(
         CFX_WideString::FromUTF8(szLocalStr.GetCStr(), szLocalStr.GetLength()));
   }
   if (!pLocale) {
     return;
   }
   CFX_WideString strRet;
@@ skipping 1929 matching lines @@
   int32_t argc = args.GetLength();
   if (argc >= 2) {
     FXJSE_HVALUE argOne = GetSimpleHValue(hThis, args, 0);
     FXJSE_HVALUE argTwo = GetSimpleHValue(hThis, args, 1);
     CFX_ByteString szPattern;
     HValueToUTF8String(argOne, szPattern);
     CFX_ByteString szValue;
     HValueToUTF8String(argTwo, szValue);
     CXFA_Document* pDoc = pContext->GetDocument();
     IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
-    CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-    FXSYS_assert(pThisNode->IsNode());
-    CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+    CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+    FXSYS_assert(pThisNode);
+    CXFA_WidgetData widgetData(pThisNode);
     IFX_Locale* pLocale = widgetData.GetLocal();
     FX_DWORD patternType;
     FX_BOOL bCompelte = XFA_PATTERN_STRING_Type(szPattern, patternType);
     CFX_WideString wsPattern =
         CFX_WideString::FromUTF8(szPattern, szPattern.GetLength());
     CFX_WideString wsValue =
         CFX_WideString::FromUTF8(szValue, szValue.GetLength());
     if (!bCompelte) {
       switch (patternType) {
         case XFA_VT_DATETIME: {
@@ skipping 189 matching lines @@
     FXJSE_HVALUE argTwo = GetSimpleHValue(hThis, args, 1);
     if (HValueIsNull(hThis, argTwo)) {
       FXJSE_Value_SetNull(args.GetReturnValue());
     } else {
       CFX_ByteString szPattern;
       HValueToUTF8String(argOne, szPattern);
       CFX_ByteString szValue;
       HValueToUTF8String(argTwo, szValue);
       CXFA_Document* pDoc = pContext->GetDocument();
       IFX_LocaleMgr* pMgr = (IFX_LocaleMgr*)pDoc->GetLocalMgr();
-      CXFA_Object* pThisNode = pDoc->GetScriptContext()->GetThisObject();
-      FXSYS_assert(pThisNode->IsNode());
-      CXFA_WidgetData widgetData((CXFA_Node*)pThisNode);
+      CXFA_Node* pThisNode = ToNode(pDoc->GetScriptContext()->GetThisObject());
+      FXSYS_assert(pThisNode);
+      CXFA_WidgetData widgetData(pThisNode);
       IFX_Locale* pLocale = widgetData.GetLocal();
       FX_DWORD patternType;
       FX_BOOL bCompletePattern =
           XFA_PATTERN_STRING_Type(szPattern, patternType);
       CFX_WideString wsPattern =
           CFX_WideString::FromUTF8(szPattern, szPattern.GetLength());
       CFX_WideString wsValue =
           CFX_WideString::FromUTF8(szValue, szValue.GetLength());
       CFX_ByteString szParsedValue;
       if (bCompletePattern) {
@@ skipping 2159 matching lines @@
       index++;
     }
   }
   for (int32_t i = iStart; i < argc; i++) {
     FXJSE_Value_Release(argsValue[i]);
   }
   FX_Free(argsValue);
 }
 void CXFA_FM2JSContext::GetObjectDefaultValue(FXJSE_HVALUE hObjectValue,
                                               FXJSE_HVALUE hDefaultValue) {
-  CXFA_Object* pNode = (CXFA_Object*)FXJSE_Value_ToObject(hObjectValue, NULL);
-  if (pNode && pNode->IsNode()) {
-    ((CXFA_Node*)pNode)
-        ->Script_Som_DefaultValue(hDefaultValue, FALSE, (XFA_ATTRIBUTE)-1);
+  CXFA_Node* pNode =
+      ToNode((CXFA_Object*)FXJSE_Value_ToObject(hObjectValue, NULL));
+  if (pNode) {
+    pNode->Script_Som_DefaultValue(hDefaultValue, FALSE, (XFA_ATTRIBUTE)-1);
   } else {
     FXJSE_Value_SetNull(hDefaultValue);
   }
 }
 FX_BOOL CXFA_FM2JSContext::SetObjectDefaultValue(FXJSE_HVALUE hObjectValue,
                                                  FXJSE_HVALUE hNewValue) {
-  FX_BOOL bSuccess = FALSE;
-  CXFA_Object* pNode = (CXFA_Object*)FXJSE_Value_ToObject(hObjectValue, NULL);
-  if (pNode && pNode->IsNode()) {
-    ((CXFA_Node*)pNode)
-        ->Script_Som_DefaultValue(hNewValue, TRUE, (XFA_ATTRIBUTE)-1);
-    bSuccess = TRUE;
+  CXFA_Node* pNode =
+      ToNode((CXFA_Object*)FXJSE_Value_ToObject(hObjectValue, NULL));
+  if (pNode) {
+    pNode->Script_Som_DefaultValue(hNewValue, TRUE, (XFA_ATTRIBUTE)-1);
+    return TRUE;
   }
-  return bSuccess;
+  return FALSE;
 }
 void CXFA_FM2JSContext::GenerateSomExpression(const CFX_ByteStringC& szName,
                                               int32_t iIndexFlags,
                                               int32_t iIndexValue,
                                               FX_BOOL bIsStar,
                                               CFX_ByteString& szSomExp) {
   if (bIsStar) {
     szSomExp = szName + "[*]";
     return;
   }
@@ skipping 64 matching lines @@
   FX_DWORD dFlags = 0UL;
   if (bdotAccessor) {
     if (FXJSE_Value_IsNull(hRefValue)) {
       pNode = pScriptContext->GetThisObject();
       dFlags = XFA_RESOLVENODE_Siblings | XFA_RESOLVENODE_Parent;
     } else {
       pNode = (CXFA_Object*)FXJSE_Value_ToObject(hRefValue, NULL);
       FXSYS_assert(pNode);
       if (bHasNoResolveName) {
         CFX_WideString wsName;
-        if (pNode->IsNode()) {
-          CXFA_Node* pXFANode = (CXFA_Node*)pNode;
+        if (CXFA_Node* pXFANode = pNode->AsNode()) {
           pXFANode->GetAttribute(XFA_ATTRIBUTE_Name, wsName, FALSE);
         }
         if (wsName.IsEmpty()) {
           CFX_WideStringC className;
           pNode->GetClassName(className);
           wsName = FX_WSTRC(L"#") + className;
         }
         wsSomExpression = wsName + wsSomExpression;
         dFlags = XFA_RESOLVENODE_Siblings;
       } else {
@@ skipping 323 matching lines @@
   FXSYS_assert(pAppProvider);
   CFX_WideString wsFormat;
   pAppProvider->LoadString(iStringID, wsFormat);
   CFX_WideString wsMessage;
   va_list arg_ptr;
   va_start(arg_ptr, iStringID);
   wsMessage.FormatV((const FX_WCHAR*)wsFormat, arg_ptr);
   va_end(arg_ptr);
   FXJSE_ThrowMessage("", FX_UTF8Encode(wsMessage, wsMessage.GetLength()));
 }