Call CXFA_Object::ToNode() rather than C-style casting.

xfa/src/fxfa/src/parser/xfa_document_datamerger_imp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/src/foxitlib.h"
 #include "xfa/src/fxfa/src/common/xfa_utils.h"
 #include "xfa/src/fxfa/src/common/xfa_object.h"
 #include "xfa/src/fxfa/src/common/xfa_document.h"
@@ skipping 441 matching lines @@
   if (bUpLevel || wsRef != FX_WSTRC(L"name")) {
     dFlags |= (XFA_RESOLVENODE_Parent | XFA_RESOLVENODE_Siblings);
   }
   XFA_RESOLVENODE_RS rs;
   pDocument->GetScriptContext()->ResolveObjects(pDataScope, wsRef, rs, dFlags,
                                                 pTemplateNode);
   if (rs.dwFlags == XFA_RESOLVENODE_RSTYPE_CreateNodeAll ||
       rs.dwFlags == XFA_RESOLVENODE_RSTYPE_CreateNodeMidAll ||
       rs.nodes.GetSize() > 1) {
     return pDocument->GetNotBindNode(rs.nodes);
-  } else if (rs.dwFlags == XFA_RESOLVENODE_RSTYPE_CreateNodeOne) {
+  }
+  if (rs.dwFlags == XFA_RESOLVENODE_RSTYPE_CreateNodeOne) {
     CXFA_Object* pObject = (rs.nodes.GetSize() > 0) ? rs.nodes[0] : NULL;
-    CXFA_Node* pNode =
-        (pObject && pObject->IsNode()) ? (CXFA_Node*)pObject : NULL;
-    if (!bForceBind && (pNode != NULL) && pNode->HasBindItem()) {
+    CXFA_Node* pNode = ToNode(pObject);
+    if (!bForceBind && pNode && pNode->HasBindItem()) {
       pNode = NULL;
     }
     return pNode;
   }
   return NULL;
 }
 CXFA_Node* XFA_DataMerge_FindFormDOMInstance(CXFA_Document* pDocument,
                                              XFA_ELEMENT eClassID,
                                              FX_DWORD dwNameHash,
                                              CXFA_Node* pFormParent) {
@@ skipping 356 matching lines @@
           pFirstInstance = pSubformNode;
         }
         XFA_DataMerge_CreateDataBinding(pSubformNode, pDataNode);
         FXSYS_assert(pSubformNode);
         subformMapArray.SetAt(pSubformNode, pDataNode);
         subformArray.Add(pSubformNode);
       }
       subformMapArray.GetStartPosition();
       for (int32_t iIndex = 0; iIndex < subformArray.GetSize(); iIndex++) {
         CXFA_Node* pSubform = subformArray[iIndex];
-        CXFA_Node* pDataNode = (CXFA_Node*)subformMapArray.GetValueAt(pSubform);
+        CXFA_Node* pDataNode =
+            reinterpret_cast<CXFA_Node*>(subformMapArray.GetValueAt(pSubform));
         for (CXFA_Node* pTemplateChild =
                  pTemplateNode->GetNodeItem(XFA_NODEITEM_FirstChild);
              pTemplateChild; pTemplateChild = pTemplateChild->GetNodeItem(
                                  XFA_NODEITEM_NextSibling)) {
           if (XFA_NeedGenerateForm(pTemplateChild, bUseInstanceManager)) {
             XFA_NodeMerge_CloneOrMergeContainer(pDocument, pSubform,
                                                 pTemplateChild, TRUE);
           } else if (pTemplateChild->GetObjectType() ==
                      XFA_OBJECTTYPE_ContainerNode) {
             pDocument->DataMerge_CopyContainer(pTemplateChild, pSubform,
@@ skipping 301 matching lines @@
         if (!bDataRef || bParentDataRef) {
           FX_DWORD dwNameHash = pFormNode->GetNameHash();
           if (dwNameHash != 0 && !pDataNode) {
             pDataNode = XFA_DataMerge_GetGlobalBinding(pDocument, dwNameHash);
             if (!pDataNode) {
               XFA_ELEMENT eDataNodeType = (eClassID == XFA_ELEMENT_Subform ||
                                            XFA_FieldIsMultiListBox(pFormNode))
                                               ? XFA_ELEMENT_DataGroup
                                               : XFA_ELEMENT_DataValue;
               CXFA_Node* pRecordNode =
-                  (CXFA_Node*)pDocument->GetXFAObject(XFA_HASHCODE_Record);
+                  ToNode(pDocument->GetXFAObject(XFA_HASHCODE_Record));
               pDataNode = XFA_DataDescription_MaybeCreateDataNode(
                   pDocument, pRecordNode, eDataNodeType,
                   pFormNode->GetCData(XFA_ATTRIBUTE_Name));
               if (pDataNode) {
                 XFA_DataMerge_CreateDataBinding(pFormNode, pDataNode, FALSE);
                 XFA_DataMerge_RegisterGlobalBinding(
                     pDocument, pFormNode->GetNameHash(), pDataNode);
               }
             } else {
               XFA_DataMerge_CreateDataBinding(pFormNode, pDataNode);
             }
           }
           if (!pDataNode) {
             XFA_DataMerge_FormValueNode_MatchNoneCreateChild(pFormNode);
           }
         }
         break;
       case XFA_ATTRIBUTEENUM_DataRef: {
         bMatchRef = bDataRef;
         bParentDataRef = TRUE;
         if (!pDataNode && bDataRef) {
           CFX_WideStringC wsRef =
               pTemplateNodeBind->GetCData(XFA_ATTRIBUTE_Ref);
           FX_DWORD dFlags =
               XFA_RESOLVENODE_Children | XFA_RESOLVENODE_CreateNode;
           XFA_RESOLVENODE_RS rs;
           pDocument->GetScriptContext()->ResolveObjects(pDataScope, wsRef, rs,
                                                         dFlags, pTemplateNode);
           CXFA_Object* pObject = (rs.nodes.GetSize() > 0) ? rs.nodes[0] : NULL;
-          pDataNode =
-              (pObject && pObject->IsNode()) ? (CXFA_Node*)pObject : NULL;
+          pDataNode = ToNode(pObject);
           if (pDataNode) {
             XFA_DataMerge_CreateDataBinding(
                 pFormNode, pDataNode,
                 rs.dwFlags == XFA_RESOVENODE_RSTYPE_ExistNodes);
           } else {
             XFA_DataMerge_FormValueNode_MatchNoneCreateChild(pFormNode);
           }
         }
       } break;
       default:
@@ skipping 65 matching lines @@
     } break;
     case XFA_ATTRIBUTEENUM_Global: {
       FX_DWORD dwNameHash = pFormNode->GetNameHash();
       if (dwNameHash != 0 && !pDataNode) {
         pDataNode = XFA_DataMerge_GetGlobalBinding(pDocument, dwNameHash);
         if (!pDataNode) {
           XFA_ELEMENT eDataNodeType = eClassID == XFA_ELEMENT_Subform
                                           ? XFA_ELEMENT_DataGroup
                                           : XFA_ELEMENT_DataValue;
           CXFA_Node* pRecordNode =
-              (CXFA_Node*)pDocument->GetXFAObject(XFA_HASHCODE_Record);
+              ToNode(pDocument->GetXFAObject(XFA_HASHCODE_Record));
           pDataNode = XFA_DataDescription_MaybeCreateDataNode(
               pDocument, pRecordNode, eDataNodeType,
               pFormNode->GetCData(XFA_ATTRIBUTE_Name));
         }
         if (pDataNode) {
           XFA_DataMerge_CreateDataBinding(pFormNode, pDataNode, FALSE);
           XFA_DataMerge_RegisterGlobalBinding(
               pDocument, pFormNode->GetNameHash(), pDataNode);
         }
       }
     } break;
     case XFA_ATTRIBUTEENUM_DataRef: {
       if (!pDataNode) {
         CFX_WideStringC wsRef = pTemplateNodeBind->GetCData(XFA_ATTRIBUTE_Ref);
         FX_DWORD dFlags = XFA_RESOLVENODE_Children |
                           XFA_RESOLVENODE_Attributes |
                           XFA_RESOLVENODE_Siblings | XFA_RESOLVENODE_Parent |
                           XFA_RESOLVENODE_CreateNode;
         XFA_RESOLVENODE_RS rs;
         pDocument->GetScriptContext()->ResolveObjects(pDataScope, wsRef, rs,
                                                       dFlags, pTemplateNode);
         CXFA_Object* pObject = (rs.nodes.GetSize() > 0) ? rs.nodes[0] : NULL;
-        pDataNode = (pObject && pObject->IsNode()) ? (CXFA_Node*)pObject : NULL;
+        pDataNode = ToNode(pObject);
         if (pDataNode) {
           XFA_DataMerge_CreateDataBinding(pFormNode, pDataNode, FALSE);
         }
       }
     } break;
   }
 }
 if(eClassID == XFA_ELEMENT_Subform || eClassID == XFA_ELEMENT_ExclGroup || eClassID == XFA_ELEMENT_SubformSet || eClassID == XFA_ELEMENT_Area || eClassID == XFA_ELEMENT_PageArea)
 {
   for (CXFA_Node* pFormChild = pFormNode->GetNodeItem(XFA_NODEITEM_FirstChild);
@@ skipping 14 matching lines @@
 CXFA_Node* XFA_DataMerge_FindDataScope(CXFA_Node* pParentFormNode) {
   for (CXFA_Node* pRootBoundNode = pParentFormNode;
        pRootBoundNode &&
        pRootBoundNode->GetObjectType() == XFA_OBJECTTYPE_ContainerNode;
        pRootBoundNode = pRootBoundNode->GetNodeItem(XFA_NODEITEM_Parent)) {
     CXFA_Node* pDataScope = pRootBoundNode->GetBindData();
     if (pDataScope) {
       return pDataScope;
     }
   }
-  return (CXFA_Node*)pParentFormNode->GetDocument()->GetXFAObject(
-      XFA_HASHCODE_Data);
+  return ToNode(
+      pParentFormNode->GetDocument()->GetXFAObject(XFA_HASHCODE_Data));
 }
 void CXFA_Document::DataMerge_UpdateBindingRelations(
     CXFA_Node* pFormUpdateRoot) {
   CXFA_Node* pDataScope = XFA_DataMerge_FindDataScope(
       pFormUpdateRoot->GetNodeItem(XFA_NODEITEM_Parent));
   if (!pDataScope) {
     return;
   }
 #ifdef XFA_DATAMERGE_UPDATEBINDINGRELATIONS_DFS
   XFA_DataMerge_UpdateBindingRelations(this, pFormUpdateRoot, pDataScope, FALSE,
                                        FALSE);
   XFA_DataMerge_UpdateBindingRelations(this, pFormUpdateRoot, pDataScope, TRUE,
                                        FALSE);
 #else
   CFX_PtrList rgFormNodeList, rgDataScopeList;
   rgFormNodeList.AddTail(pFormUpdateRoot);
   rgDataScopeList.AddTail(pDataScope);
   while (rgFormNodeList.GetCount()) {
     FX_POSITION pos;
     pos = rgFormNodeList.GetHeadPosition();
-    CXFA_Node* pCurFormNode = (CXFA_Node*)rgFormNodeList.GetAt(pos);
+    CXFA_Node* pCurFormNode = ToNode(rgFormNodeList.GetAt(pos));
     rgFormNodeList.RemoveAt(pos);
     pos = rgDataScopeList.GetHeadPosition();
-    CXFA_Node* pCurDataScope = (CXFA_Node*)rgDataScopeList.GetAt(pos);
+    CXFA_Node* pCurDataScope = ToNode(rgDataScopeList.GetAt(pos));
     rgDataScopeList.RemoveAt(pos);
     XFA_DataMerge_UpdateBindingRelations(this, pCurFormNode, pCurDataScope,
                                          rgFormNodeList, rgDataScopeList);
   }
 #endif
 }
 CXFA_Node* CXFA_Document::GetNotBindNode(CXFA_ObjArray& arrayNodes) {
   for (int32_t i = 0; i < arrayNodes.GetSize(); i++) {
-    CXFA_Object* pObject = arrayNodes[i];
-    if (!pObject->IsNode()) {
-      continue;
-    }
-    if (((CXFA_Node*)pObject)->HasBindItem()) {
-      continue;
-    }
-    return ((CXFA_Node*)pObject);
+    CXFA_Node* pNode = arrayNodes[i]->AsNode();
+    if (pNode && !pNode->HasBindItem())
+      return pNode;
   }
-  return NULL;
+  return nullptr;
 }
 void CXFA_Document::DoDataMerge() {
-  CXFA_Node* pDatasetsRoot = (CXFA_Node*)GetXFAObject(XFA_HASHCODE_Datasets);
+  CXFA_Node* pDatasetsRoot = ToNode(GetXFAObject(XFA_HASHCODE_Datasets));
   if (!pDatasetsRoot) {
     IFDE_XMLElement* pDatasetsXMLNode =
         IFDE_XMLElement::Create(FX_WSTRC(L"xfa:datasets"));
     FXSYS_assert(pDatasetsXMLNode);
     pDatasetsXMLNode->SetString(
         FX_WSTRC(L"xmlns:xfa"),
         FX_WSTRC(L"http://www.xfa.org/schema/xfa-data/1.0/"));
     pDatasetsRoot = CreateNode(XFA_XDPPACKET_Datasets, XFA_ELEMENT_DataModel);
     pDatasetsRoot->SetCData(XFA_ATTRIBUTE_Name, FX_WSTRC(L"datasets"));
     m_pRootNode->GetXMLMappingNode()->InsertChildNode(pDatasetsXMLNode);
@@ skipping 133 matching lines @@
           pNode = sIterator.MoveToNext();
         }
       } else {
         pNode->SetFlag(XFA_NODEFLAG_Initialized);
         pNode = sIterator.MoveToNext();
       }
     }
   }
 }
 void CXFA_Document::DoDataRemerge(FX_BOOL bDoDataMerge) {
-  CXFA_Node* pFormRoot = (CXFA_Node*)this->GetXFAObject(XFA_HASHCODE_Form);
+  CXFA_Node* pFormRoot = ToNode(GetXFAObject(XFA_HASHCODE_Form));
   if (pFormRoot) {
     while (CXFA_Node* pNode = pFormRoot->GetNodeItem(XFA_NODEITEM_FirstChild)) {
       pFormRoot->RemoveChild(pNode);
     }
     pFormRoot->SetObject(XFA_ATTRIBUTE_BindingNode, NULL);
   }
   XFA_DataMerge_ClearGlobalBinding(this);
   if (bDoDataMerge) {
     DoDataMerge();
   }
   CXFA_LayoutProcessor* pLayoutProcessor = GetLayoutProcessor();
   pLayoutProcessor->SetForceReLayout(TRUE);
 }