Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp

Issue 1668003003: Call CXFA_Object::ToNode() rather than C-style casting. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp
diff --git a/xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp b/xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp
index 39e8d29c5904e104cd58ad2d29c3886664815deb..ee42d5a4fcb545df9bd5cc4d0361b44f90033e60 100644
--- a/xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp
+++ b/xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp
@@ -305,7 +305,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_OpenList(
if (iLength >= 1) {
FXJSE_HVALUE hValue = pArguments->GetValue(0);
if (FXJSE_Value_IsObject(hValue)) {
- pNode = (CXFA_Node*)FXJSE_Value_ToObject(hValue, NULL);
+ pNode = static_cast<CXFA_Node*>(FXJSE_Value_ToObject(hValue, nullptr));
} else if (FXJSE_Value_IsUTF8String(hValue)) {
CFX_ByteString bsString;
FXJSE_Value_ToUTF8String(hValue, bsString);
@@ -330,7 +330,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_OpenList(
FXJSE_Value_Release(hValue);
return;
}
- pNode = (CXFA_Node*)resoveNodeRS.nodes[0];
+ pNode = resoveNodeRS.nodes[0]->AsNode();
}
FXJSE_Value_Release(hValue);
}
@@ -463,7 +463,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_ResetData(
if (iRet < 1 || !resoveNodeRS.nodes[0]->IsNode()) {
continue;
}
- pNode = (CXFA_Node*)resoveNodeRS.nodes[0];
+ pNode = resoveNodeRS.nodes[0]->AsNode();
pNotify->ResetData(pNode->GetWidgetData());
}
if (!pNode) {
@@ -508,7 +508,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_SetFocus(
if (iLength >= 1) {
FXJSE_HVALUE hValue = pArguments->GetValue(0);
if (FXJSE_Value_IsObject(hValue)) {
- pNode = (CXFA_Node*)FXJSE_Value_ToObject(hValue, NULL);
+ pNode = static_cast<CXFA_Node*>(FXJSE_Value_ToObject(hValue, NULL));
} else if (FXJSE_Value_IsUTF8String(hValue)) {
CFX_ByteString bsString;
FXJSE_Value_ToUTF8String(hValue, bsString);
@@ -533,7 +533,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_SetFocus(
FXJSE_Value_Release(hValue);
return;
}
- pNode = (CXFA_Node*)resoveNodeRS.nodes[0];
+ pNode = resoveNodeRS.nodes[0]->AsNode();
}
FXJSE_Value_Release(hValue);
}

Powered by Google App Engine
This is Rietveld 408576698