xfa/src/fxfa/src/app/xfa_ffdochandler.cpp - Issue 1668003003: Call CXFA_Object::ToNode() rather than C-style casting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/app/xfa_ffdochandler.cpp

Issue 1668003003: Call CXFA_Object::ToNode() rather than C-style casting. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/app/xfa_ffdochandler.cpp

diff --git a/xfa/src/fxfa/src/app/xfa_ffdochandler.cpp b/xfa/src/fxfa/src/app/xfa_ffdochandler.cpp

index 2fac3449adeec51b0060ed83366bc87504198f77..3bb4bfdc58d7adc4dfe69693ec1792aa8629d657 100644

--- a/xfa/src/fxfa/src/app/xfa_ffdochandler.cpp

+++ b/xfa/src/fxfa/src/app/xfa_ffdochandler.cpp

@@ -79,7 +79,7 @@ XFA_ATTRIBUTEENUM CXFA_FFDocHandler::GetRestoreState(IXFA_Doc* hDoc) {

if (!pXFADoc) {

return XFA_ATTRIBUTEENUM_Unknown;

}

- CXFA_Node* pForm = (CXFA_Node*)pXFADoc->GetXFAObject(XFA_HASHCODE_Form);

+ CXFA_Node* pForm = ToNode(pXFADoc->GetXFAObject(XFA_HASHCODE_Form));

if (!pForm) {

return XFA_ATTRIBUTEENUM_Unknown;

}