Add product mode:

Add product mode:
- Add PRODUCT define and build mode to gyp configurations.
- Add product mode to test harness.
- Start to unify list of flags.
- Allow flags to be constant for particular build configurations.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c0c6cb5c2212fd53a1f57dee6c968410c61fcd2

[Ivan Posva, 2016-02-03 16:32:38]

iposva@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com

[Ivan Posva, 2016-02-03 16:32:38]

Suggestion on how to add a product build.

-Ivan

[Cutch, 2016-02-03 17:09:01]

LGTMwC

https://codereview.chromium.org/1663863002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/1663863002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:2330: case 'debug': mode = 'Debug';
newline

[Florian Schneider, 2016-02-03 18:00:20]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-02-03 18:00:21]

dbc: To keep our gyp build files in sync I'd also update
tools/gyp/configurations_msvs.gypi and tools/gyp/configurations_android.gypi
with product mode -- as a first step maybe just make product == release in these
files.

https://codereview.chromium.org/1663863002/diff/1/runtime/tools/gyp/runtime-c...
File runtime/tools/gyp/runtime-configurations.gypi (right):

https://codereview.chromium.org/1663863002/diff/1/runtime/tools/gyp/runtime-c...
runtime/tools/gyp/runtime-configurations.gypi:105: 'xcode_settings': {
Why is xcode_settings not in configurations_xcode.gypi? I think it works either
way, but seems a bit strange.

https://codereview.chromium.org/1663863002/diff/1/tools/gyp/configurations.gypi
File tools/gyp/configurations.gypi (right):

https://codereview.chromium.org/1663863002/diff/1/tools/gyp/configurations.gy...
tools/gyp/configurations.gypi:199: 
Add ProductX64, ProductXARM, ProductXARM64, etc?

[Ivan Posva, 2016-02-03 18:39:12]

On 2016/02/03 18:00:21, Florian Schneider wrote:
> dbc: To keep our gyp build files in sync I'd also update
> tools/gyp/configurations_msvs.gypi and tools/gyp/configurations_android.gypi
> with product mode -- as a first step maybe just make product == release in
these
> files.
> 
>
https://codereview.chromium.org/1663863002/diff/1/runtime/tools/gyp/runtime-c...
> File runtime/tools/gyp/runtime-configurations.gypi (right):
> 
>
https://codereview.chromium.org/1663863002/diff/1/runtime/tools/gyp/runtime-c...
> runtime/tools/gyp/runtime-configurations.gypi:105: 'xcode_settings': {
> Why is xcode_settings not in configurations_xcode.gypi? I think it works
either
> way, but seems a bit strange.
> 
>
https://codereview.chromium.org/1663863002/diff/1/tools/gyp/configurations.gypi
> File tools/gyp/configurations.gypi (right):
> 
>
https://codereview.chromium.org/1663863002/diff/1/tools/gyp/configurations.gy...
> tools/gyp/configurations.gypi:199: 
> Add ProductX64, ProductXARM, ProductXARM64, etc?

As hinted to in the initial message this a suggestion. Seems like apart from the
missing pieces there is agreement.

-Ivan

[siva, 2016-02-03 20:33:51]

https://codereview.chromium.org/1663863002/diff/1/runtime/vm/symbols.cc
File runtime/vm/symbols.cc (right):

https://codereview.chromium.org/1663863002/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:40: "Dump symbol table statistics");
Do you anticipate the product value being different from the default value in
some cases?

I was wondering if it is possible to set the default values to be what we want
in a product build.

Maybe the service isolate related parameters could potentially have different
values.

Could we use macros like
#define kProductTrue true
#define kProductFalse false
#define kDefaultTrue true
#define kDefaultFalse false

PRODUCT_FLAG(kProductFalse, bool dump_symbol_stats, kDefaultFalse...
to make it more readable as to which bool refers to product vs default

[Ivan Posva, 2016-02-03 22:11:08]

https://codereview.chromium.org/1663863002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/1663863002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:2330: case 'debug': mode = 'Debug';
On 2016/02/03 17:09:01, Cutch wrote:
> newline

Done.

[Ivan Posva, 2016-02-04 01:27:17]

PTAL

-Ivan

[Florian Schneider, 2016-02-04 01:58:00]

lgtm

[Ivan Posva, 2016-02-04 05:08:52]

Description was changed from

==========
Add product mode:
- Add PRODUCT define and build mode to gyp configurations.
- Add product mode to test harness.
- Add PRODUCT_FLAG define to use for hard-wired flags in
  product mode.
==========

to

==========
Add product mode:
- Add PRODUCT define and build mode to gyp configurations.
- Add product mode to test harness.
- Start to unify list of flags.
- Allow flags to be constant for particular build configurations.
==========

[Ivan Posva, 2016-02-04 05:10:34]

Description was changed from

==========
Add product mode:
- Add PRODUCT define and build mode to gyp configurations.
- Add product mode to test harness.
- Start to unify list of flags.
- Allow flags to be constant for particular build configurations.
==========

to

==========
Add product mode:
- Add PRODUCT define and build mode to gyp configurations.
- Add product mode to test harness.
- Start to unify list of flags.
- Allow flags to be constant for particular build configurations.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c0c6cb5c2212fd53a1f57dee6c968410c61fcd2
==========

[Ivan Posva, 2016-02-04 05:10:35]

Committed patchset #3 (id:40001) manually as
9c0c6cb5c2212fd53a1f57dee6c968410c61fcd2 (presubmit successful).