Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: runtime/vm/flags.cc

Issue 1663863002: Add product mode: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reworked the flags setting: Moving to single file for all flag defintions. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flags.h ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flags.cc
diff --git a/runtime/vm/flags.cc b/runtime/vm/flags.cc
index c1ec041c7284e60fecd3a8a868a952ed979fc205..e9bd84fbb4371a33de52de79545dbb0a813c4012 100644
--- a/runtime/vm/flags.cc
+++ b/runtime/vm/flags.cc
@@ -14,6 +14,41 @@ DEFINE_FLAG(bool, print_flags, false, "Print flags as they are being parsed.");
DEFINE_FLAG(bool, ignore_unrecognized_flags, false,
"Ignore unrecognized flags.");
+#define PRODUCT_FLAG_MARCO(name, type, default_value, comment) \
+ type FLAG_##name = Flags::Register_##type(&FLAG_##name, \
+ #name, \
+ default_value, \
+ comment);
+
+#if defined(DEBUG)
+#define DEBUG_FLAG_MARCO(name, type, default_value, comment) \
+ type FLAG_##name = Flags::Register_##type(&FLAG_##name, \
+ #name, \
+ default_value, \
+ comment);
+#else // defined(DEBUG)
+#define DEBUG_FLAG_MARCO(name, type, default_value, comment)
+#endif // defined(DEBUG)
+
+#if defined(PRODUCT)
+// Nothing to be done for the product flag definitions.
+#define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment)
+#else // defined(PRODUCT)
+#define RELEASE_FLAG_MARCO(name, product_value, type, default_value, comment) \
+ type FLAG_##name = Flags::Register_##type(&FLAG_##name, \
+ #name, \
+ default_value, \
+ comment);
+#endif // defined(PRODUCT)
+
+// Define all of the non-product flags here.
+FLAG_LIST(PRODUCT_FLAG_MARCO, RELEASE_FLAG_MARCO, DEBUG_FLAG_MARCO)
+
+#undef RELEASE_FLAG_MARCO
+#undef DEBUG_FLAG_MARCO
+#undef PRODUCT_FLAG_MARCO
+
+
bool Flags::initialized_ = false;
// List of registered flags.
« no previous file with comments | « runtime/vm/flags.h ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698