Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/gyp/configurations_android.gypi

Issue 1663863002: Add product mode: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reworked the flags setting: Moving to single file for all flag defintions. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gyp/configurations.gypi ('k') | tools/gyp/configurations_make.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/configurations_android.gypi
diff --git a/tools/gyp/configurations_android.gypi b/tools/gyp/configurations_android.gypi
index 80ff1c66b27d600f8b1d53134cca29fe90ad75e1..0d6133dabf1cdda3ab5af9448f9538f056571cfc 100644
--- a/tools/gyp/configurations_android.gypi
+++ b/tools/gyp/configurations_android.gypi
@@ -51,15 +51,8 @@
'defines': [
'DEBUG',
],
- 'conditions': [
- ['c_frame_pointers==1', {
- 'cflags': [
- '-fno-omit-frame-pointer',
- ],
- 'defines': [
- 'NATIVE_CODE_HAS_FRAME_POINTERS'
- ],
- }],
+ 'cflags': [
+ '-fno-omit-frame-pointer',
],
},
'Dart_Android_Release': {
@@ -72,19 +65,26 @@
'-Os',
],
'cflags': [
+ '-fno-omit-frame-pointer',
'-fdata-sections',
'-ffunction-sections',
'-O3',
],
- 'conditions': [
- ['c_frame_pointers==1', {
- 'cflags': [
- '-fno-omit-frame-pointer',
- ],
- 'defines': [
- 'NATIVE_CODE_HAS_FRAME_POINTERS'
- ],
- }],
+ },
+ 'Dart_Android_Product': {
+ 'abstract': 1,
+ 'defines': [
+ 'NDEBUG',
+ 'PRODUCT',
+ ],
+ 'cflags!': [
+ '-O2',
+ '-Os',
+ ],
+ 'cflags': [
+ '-fdata-sections',
+ '-ffunction-sections',
+ '-O3',
],
},
'Dart_Android_ia32_Base': {
« no previous file with comments | « tools/gyp/configurations.gypi ('k') | tools/gyp/configurations_make.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698